CARVIEW |
Select Language
HTTP/2 200
date: Sat, 11 Oct 2025 12:11:35 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com github.githubassets.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com wss://alive-staging.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com marketplace-screenshots.githubusercontent.com/ copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=335.653691,conversation_content-fragment;desc="conversation_content fragment";dur=342.156481,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=433.956338,nginx;desc="NGINX";dur=1.097138,glb;desc="GLB";dur=140.57721
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: aab62e3
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=v8o9ofpk1fcBUGsFHK4n%2F5eLUbFotlC75VctM1wNEx6TM0gXfouXItq6b38qIKcFcYYBDpYABj2jtFJ3g03GX0phiF4b963Polmx3Bdx8p%2B6hJKrzSL%2BBX7IzzglCRGllN3%2BcqQ0PfXHGBQnfpE2KhWdhoGToZPfGqxEbc6sH2rBQygfNXcWZTLtoaEGXB04DG%2B800sz0wZISw1PvXJV%2FxAdLsXveQWXjz3vmRmkHY%2BNMfsaexjutbZ2aYhKzWB1CakgYSPhfWrO3MXEff6qRQ%3D%3D--9BmZJYecFOfFu2oR--TJ7OyWsHpoOisqsMnJXSgg%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1561635709.1760184695; Path=/; Domain=github.com; Expires=Sun, 11 Oct 2026 12:11:35 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sun, 11 Oct 2026 12:11:35 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: C93A:8729A:46F0D8:5A16C6:68EA4977
Make engine routes filterable in bin/rails routes, improve engine formatting by gmcgibbon · Pull Request #55752 · rails/rails · GitHub
gmcgibbon
force-pushed
the
engine_routes_filter
branch
from
September 24, 2025 06:28
gmcgibbon
force-pushed
the
engine_routes_filter
branch
from
September 24, 2025 06:30
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 22k
Make engine routes filterable in bin/rails routes, improve engine formatting #55752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+164
−63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
dfc04be
to
b943a4b
Compare
…matting Allow engine routes to be filterable in the routing inspector, and improve formatting of engine routing output. Co-authored-by: Dennis Paagman <dennis@paagman.dev>
b943a4b
to
2831cd0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Motivation / Background
This Pull Request has been created because as mentioned in #54573, the output of
bin/rails routes
doesn't filter engine routes properly.Closes #54573
Detail
This Pull Request changes the routing inspect to do the following:
Additional information
Since we rewrote how routes are collected and printed, I did a quick
time
benchmark on a large app to make sure we're not slowing things down:Before:
After:
Same-ish to a bit faster on a full print. Applying a filter is slightly slower, but that's expected because it iterates through all routes (app and engine) now instead of lazy unfurling that previously missed embedded routes.
Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]