CARVIEW |
Select Language
HTTP/2 200
date: Sat, 11 Oct 2025 20:14:07 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com github.githubassets.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com wss://alive-staging.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com marketplace-screenshots.githubusercontent.com/ copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=327.190418,conversation_content-fragment;desc="conversation_content fragment";dur=972.68552,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=404.702687,nginx;desc="NGINX";dur=1.151837,glb;desc="GLB";dur=145.166896
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: aab62e3
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=QZeHhsNDZzIucPySKcSDxLYLLA8nYT%2BEHLHrcCuFNFv%2FlA6xXtCmpWfCKs4OuJZONFxayesvscIHMoS7fxKfJYDXO7F5y%2BXU%2F9VtXy9qvEqQF3qvcIztimtO9kBsPd0Z6v9YqqChZ30b%2FF717Z75oiGpgQwEbRnR1ZVzN5WwZ%2FXwWbcPMbkmeujO8G7KbP6Q1b7lhww83nshqC7tjnfzNJNfULq2E6hNwirdwnEXRcCSdfDTUjzpiOk8uSyxBmcratgdwBm9tzPgVaksGYtjdA%3D%3D--0iHjJjMhOcPlHCgU--B5EE20UwjvFHsWtt9LZ%2Fww%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.361596264.1760213646; Path=/; Domain=github.com; Expires=Sun, 11 Oct 2026 20:14:06 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sun, 11 Oct 2026 20:14:06 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: 8CD4:C7FF0:A0EFEF:D28D52:68EABA8E
Fix time attribute dirty tracking with timezone conversions by prateekkish · Pull Request #55298 · rails/rails · GitHub
prateekkish
force-pushed
the
feature/use-fixed-date-for-time-attrs
branch
from
July 5, 2025 18:10
prateekkish
force-pushed
the
feature/use-fixed-date-for-time-attrs
branch
from
July 5, 2025 18:18
prateekkish
force-pushed
the
feature/use-fixed-date-for-time-attrs
branch
2 times, most recently
from
August 27, 2025 04:18
byroot
force-pushed
the
feature/use-fixed-date-for-time-attrs
branch
2 times, most recently
from
September 18, 2025 11:22
byroot
force-pushed
the
feature/use-fixed-date-for-time-attrs
branch
from
September 18, 2025 11:52
byroot
force-pushed
the
feature/use-fixed-date-for-time-attrs
branch
from
September 18, 2025 12:10
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 22k
Fix time attribute dirty tracking with timezone conversions #55298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
byroot
merged 1 commit into
rails:main
from
prateekkish:feature/use-fixed-date-for-time-attrs
Sep 18, 2025
Merged
Fix time attribute dirty tracking with timezone conversions #55298
byroot
merged 1 commit into
rails:main
from
prateekkish:feature/use-fixed-date-for-time-attrs
Sep 18, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
39265f2
to
a495e25
Compare
a495e25
to
ef2f0ce
Compare
Is a configuration really needed? What's the reason not to want that behavior? |
751c5e6
to
9190b43
Compare
@byroot This looks ready to me. Could you help with a review or tagging somebody who might? |
56bddc6
to
52b0ded
Compare
byroot
reviewed
Sep 18, 2025
52b0ded
to
44eb9b3
Compare
When time-only attributes are used with timezone-aware settings, they can be incorrectly marked as changed due to date shifts during timezone conversion. This happens because timezone conversions can change the internal date component (e.g., from 2000-01-01 to 2000-01-02) even though the time value remains the same. This commit adds a new configuration option use_fixed_date_for_time_attributes that, when enabled, ensures time-only attributes maintain a fixed date of 2000-01-01 during timezone conversions. This prevents false positive dirty tracking while maintaining backward compatibility by defaulting to false. Example usage: config.active_record.use_fixed_date_for_time_attributes = true Fixes rails#55118 Co-Authored-By: Jean Boussier <jean.boussier@gmail.com>
44eb9b3
to
8eeaa38
Compare
Thanks a bunch @byroot Happy to see this merged. |
In which version of rails will this be available? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Summary
This PR fixes an issue where time-only attributes are incorrectly marked as changed when setting the same time value due to timezone conversion causing date shifts.
Problem
When using time-only attributes with timezone-aware settings, the internal date component can shift during timezone conversions (e.g., from 2000-01-01 to 2000-01-02), causing Rails to incorrectly detect the attribute as changed even when the time value remains the same.
Before (Bug)
After (Fixed)
Solution
This PR ensures time-only attributes maintain a fixed date of 2000-01-01 during timezone conversions. This prevents false positive dirty tracking.
The fix:
TimeZoneConverter
to maintain the fixed dateFixes #55118