Hi @fatkodima, I've seen that you've done some work lately surrounding updates to the Postgres migrations and schema support in ActiveRecord. Would you mind taking a look at this and let me know if you think of it?

No need to ping anyone, just wait some time for some other reviewers (or ask for reviews in discord channel).
And please squash your PR into a single commit.

@fatkodima pushed up a squashed commit, thanks for your time

options: can be used for some database-specific options like options: 'ENGINE=InnoDB DEFAULT CHARSET=utf8mb4' for MySQL.

PostgreSQL native partition is one of them, not everything. It eventually add the string specified in the option: clause at the end of
create table <table_name> (), so it needs to consider the order of each options to be dumped to meet database specific requirements,
that should be hard for database adapter to consider every order. How about config.active_record.schema_format = :sql and run rails db:schema:dump?

Hi @yahonda. Yes, this is just one of things that options: can do and supporting all features for all adapters like this would be challenging. My thinking was that starting to add support for specific adapter features through options would be nice to have though. In terms of ordering, for Postgres the create_table option ordering is well documented and there aren't that many, in case other options were to get added in this manner:

https://www.postgresql.org/docs/current/sql-createtable.html

Using the :sql schema format does work, but many teams have a preference to use schema.rb and I'm not sure how one could easily use native partitioning otherwise. It also felt unexpected to me to use options: to correctly create the partitioned parent table (which felt like a valid use case for it) to then have it not work as expected in the test environment when the schema was loaded.

Thanks for your time, let me know what you think.

As a delayed follow-up, i pushed up support for INHERITS in this PR as well. Note that INHERITS is not compatible with PARTITION so there isn't a need to support combining those options

It's been a while so I figured I'd bump this again in hopes to revive discussion about it. I've been using this patch on a real production Rails app for about 9 months and it has been working well. I think it would be nice if Rails started to support more create_table options in schema.rb through schema dumping like this.