| CARVIEW |
Select Language
HTTP/2 200
date: Sat, 19 Jul 2025 11:19:00 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=410.216867,conversation_content-fragment;desc="conversation_content fragment";dur=1012.156906,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=332.164025,nginx;desc="NGINX";dur=1.581321,glb;desc="GLB";dur=95.783341
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: fd8fbbc
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=SB1fdojm3W%2B46AraYlXh5H33jFQMwvrUf%2B68hPpzYJCCky9WFVn23jR61zNSOVAfy1EYciy8x%2BRXMGw9svtBq7%2BbPAzl8ph%2BIlDAGD5cxjP4npEaq%2BruD1pH1lqMlwSDOkXZVqhIk2PLIpOFiDcpgj3sySyJPCpMdavY2OntiQ7jyM5YSxiCttm7JgQuaQpOFXNubB7ko%2Fbol5bAqm8GpnhovRyiMea9S4XG8Qk4rMNcIbO4jVt9uhlITygiCCrmxRLbWGdyF4CeNw0OGT9S1g%3D%3D--yjLE8Qn0ctSKeevt--p2gDATQFvtjKn1LB%2FIhyhw%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1776756435.1752923939; Path=/; Domain=github.com; Expires=Sun, 19 Jul 2026 11:18:59 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sun, 19 Jul 2026 11:18:59 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: E362:3DC509:412C31:51E4D2:687B7F23
[PyTorch] Add efficient isnan for NEON float by swolchok · Pull Request #139082 · pytorch/pytorch · GitHub
pytorch-bot
bot
added
the
module: cpu
CPU specific problem (e.g., perf, algorithm)
label
Oct 28, 2024
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 24.7k
[PyTorch] Add efficient isnan for NEON float #139082
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just test x != x rather than applying element-by-element scalar isnan. Differential Revision: [D65001633](https://our.internmc.facebook.com/intern/diff/D65001633/) [ghstack-poisoned]
pytorch-bot
bot
added
the
module: cpu
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/139082
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 05a9e2d with merge base 86602a6 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
This pull request was exported from Phabricator. Differential Revision: D65001633 |
This was referenced Oct 28, 2024
Closed
Just test x != x rather than applying element-by-element scalar isnan. Differential Revision: [D65001633](https://our.internmc.facebook.com/intern/diff/D65001633/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D65001633 |
Just test x != x rather than applying element-by-element scalar isnan. Differential Revision: [D65001633](https://our.internmc.facebook.com/intern/diff/D65001633/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D65001633 |
Just test x != x rather than applying element-by-element scalar isnan. Differential Revision: [D65001633](https://our.internmc.facebook.com/intern/diff/D65001633/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D65001633 |
This was referenced Oct 29, 2024
malfet
approved these changes
Oct 31, 2024
Just test x != x rather than applying element-by-element scalar isnan. Differential Revision: [D65001633](https://our.internmc.facebook.com/intern/diff/D65001633/) cc jgong5 mingfeima XiaobingSuper sanchitintel ashokei jingxu10 [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D65001633 |
Just test x != x rather than applying element-by-element scalar isnan. Testing: vec_test_all_types checks IsNan Differential Revision: [D65001633](https://our.internmc.facebook.com/intern/diff/D65001633/) cc jgong5 mingfeima XiaobingSuper sanchitintel ashokei jingxu10 [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D65001633 |
Just test x != x rather than applying element-by-element scalar isnan. Testing: vec_test_all_types checks IsNan Differential Revision: [D65001633](https://our.internmc.facebook.com/intern/diff/D65001633/) cc jgong5 mingfeima XiaobingSuper sanchitintel ashokei jingxu10 [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D65001633 |
pytorchmergebot
pushed a commit
that referenced
this pull request
Nov 1, 2024
Same as the efficient one for float when f16 hardware support is available. Testing: Added exhaustive isnan test coverage Differential Revision: [D65003321](https://our.internmc.facebook.com/intern/diff/D65003321/) Pull Request resolved: #139083 Approved by: https://github.com/malfet ghstack dependencies: #139082
pytorchmergebot
pushed a commit
that referenced
this pull request
Nov 1, 2024
This is the first big milestone we've been building towards! (Following rev also hooks this up to actual gemv.) Testing: To check perf, I ran python torchchat.py generate stories110M --dtype fp16 --device cpu on an x86 machine without AVX512FP16. Observed roughly 5x tokens/sec increase. Differential Revision: [D64280688](https://our.internmc.facebook.com/intern/diff/D64280688/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D64280688/)! Pull Request resolved: #137918 Approved by: https://github.com/malfet ghstack dependencies: #139082, #139083
pytorchmergebot
pushed a commit
that referenced
this pull request
Nov 1, 2024
…rchitectures (#138005) Following up on previous rev to use fp16_gemv_trans in gemv, not just gemm-used-for-gemv. Differential Revision: [D64351092](https://our.internmc.facebook.com/intern/diff/D64351092/) Pull Request resolved: #138005 Approved by: https://github.com/malfet ghstack dependencies: #139082, #139083, #137918
pytorchmergebot
pushed a commit
that referenced
this pull request
Nov 1, 2024
No real reason to have the zero-beta restriction, so let's lift it. Testing: intentionally broke new paths locally to verify test coverage existed Differential Revision: [D64407752](https://our.internmc.facebook.com/intern/diff/D64407752/) Pull Request resolved: #138275 Approved by: https://github.com/malfet ghstack dependencies: #139082, #139083, #137918, #138005
rahulsingh-intel
pushed a commit
to rahulsingh-intel/pytorch
that referenced
this pull request
Nov 5, 2024
Just test x != x rather than applying element-by-element scalar isnan. Testing: vec_test_all_types checks IsNan Differential Revision: [D65001633](https://our.internmc.facebook.com/intern/diff/D65001633/) Pull Request resolved: pytorch#139082 Approved by: https://github.com/malfet
rahulsingh-intel
pushed a commit
to rahulsingh-intel/pytorch
that referenced
this pull request
Nov 5, 2024
Same as the efficient one for float when f16 hardware support is available. Testing: Added exhaustive isnan test coverage Differential Revision: [D65003321](https://our.internmc.facebook.com/intern/diff/D65003321/) Pull Request resolved: pytorch#139083 Approved by: https://github.com/malfet ghstack dependencies: pytorch#139082
rahulsingh-intel
pushed a commit
to rahulsingh-intel/pytorch
that referenced
this pull request
Nov 5, 2024
This is the first big milestone we've been building towards! (Following rev also hooks this up to actual gemv.) Testing: To check perf, I ran python torchchat.py generate stories110M --dtype fp16 --device cpu on an x86 machine without AVX512FP16. Observed roughly 5x tokens/sec increase. Differential Revision: [D64280688](https://our.internmc.facebook.com/intern/diff/D64280688/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D64280688/)! Pull Request resolved: pytorch#137918 Approved by: https://github.com/malfet ghstack dependencies: pytorch#139082, pytorch#139083
rahulsingh-intel
pushed a commit
to rahulsingh-intel/pytorch
that referenced
this pull request
Nov 5, 2024
…rchitectures (pytorch#138005) Following up on previous rev to use fp16_gemv_trans in gemv, not just gemm-used-for-gemv. Differential Revision: [D64351092](https://our.internmc.facebook.com/intern/diff/D64351092/) Pull Request resolved: pytorch#138005 Approved by: https://github.com/malfet ghstack dependencies: pytorch#139082, pytorch#139083, pytorch#137918
rahulsingh-intel
pushed a commit
to rahulsingh-intel/pytorch
that referenced
this pull request
Nov 5, 2024
No real reason to have the zero-beta restriction, so let's lift it. Testing: intentionally broke new paths locally to verify test coverage existed Differential Revision: [D64407752](https://our.internmc.facebook.com/intern/diff/D64407752/) Pull Request resolved: pytorch#138275 Approved by: https://github.com/malfet ghstack dependencies: pytorch#139082, pytorch#139083, pytorch#137918, pytorch#138005
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ciflow/trunk
Trigger trunk jobs on your pull request
fb-exported
Merged
module: cpu
CPU specific problem (e.g., perf, algorithm)
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Stack from ghstack (oldest at bottom):
Just test x != x rather than applying element-by-element scalar isnan.
Testing: vec_test_all_types checks IsNan
Differential Revision: D65001633
cc @jgong5 @mingfeima @XiaobingSuper @sanchitintel @ashokei @jingxu10