| CARVIEW |
Select Language
HTTP/2 200
date: Sat, 19 Jul 2025 11:18:11 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=330.683877,conversation_content-fragment;desc="conversation_content fragment";dur=809.193151,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=354.75783,nginx;desc="NGINX";dur=1.131186,glb;desc="GLB";dur=95.189121
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: fd8fbbc
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=jZ%2FQHV2MUR3%2FCKN1%2FbCbY%2Bf54cLj0b43WKumg17JNssavB%2FW8a4qH1JwV5H8qMYP2pP1iuLt4nyU2FxFxe95GBttC5WIqy2eDDWnahorNP%2FyUsuI6lwU3UfNHxv32Jlrss4tmT7XNxispCE%2FB85JviFIvjsnqHDFhWxWlsVzFNO1aZYlB56yhYeCIFQpT4yms8Eka1fO8KdiQsKfAeRoNBikuCWKUdgMzTBu0HB3bxFbpcrBYL9Hi0gpQw0wrShrfe8kiySzPkB2UsSFIfJwsQ%3D%3D--8EYS3QC2jnkwnrtE--elAPSt0YPi4CBUn7S7hPQg%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.411304934.1752923890; Path=/; Domain=github.com; Expires=Sun, 19 Jul 2026 11:18:10 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sun, 19 Jul 2026 11:18:10 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: 9E5C:10A6BA:40EA4E:51A0B7:687B7EF2
fix test_lazy_module_kwargs by avikchaudhuri · Pull Request #137705 · pytorch/pytorch · GitHub
avikchaudhuri
force-pushed
the
export-D64185644
branch
from
October 10, 2024 17:14
avikchaudhuri
force-pushed
the
export-D64185644
branch
from
October 10, 2024 17:17
avikchaudhuri
force-pushed
the
export-D64185644
branch
from
October 10, 2024 21:22
avikchaudhuri
force-pushed
the
export-D64185644
branch
from
October 10, 2024 21:26
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 24.7k
fix test_lazy_module_kwargs #137705
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
fix test_lazy_module_kwargs #137705
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/137705
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (3 Unrelated Failures)As of commit 80ac69e with merge base 93bbc8a ( FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
This pull request was exported from Phabricator. Differential Revision: D64185644 |
avikchaudhuri
force-pushed
the
export-D64185644
branch
from
7ce7e9e to
880e323
Compare
|
This pull request was exported from Phabricator. Differential Revision: D64185644 |
tugsbayasgalan
approved these changes
Oct 10, 2024
| @@ -1527,6 +1527,14 @@ def _detect_attribute_assignment(mod: torch.nn.Module): | |||
| "_state_dict_hooks", | |||
| "_state_dict_pre_hooks", | |||
| "training", | |||
| ] | |||
| NN_MODULE_LAZY_STD_ATTRS = [ | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are they previously special handled in dynamo?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This only applies to non-strict, since this bug was in detecting arribute assigments (in general Dynamo errors so we don't run this detection there).
|
This pull request was exported from Phabricator. Differential Revision: D64185644 |
avikchaudhuri
added a commit
to avikchaudhuri/pytorch
that referenced
this pull request
Oct 10, 2024
Summary: Pull Request resolved: pytorch#137705 Test Plan: fixed Differential Revision: D64185644
avikchaudhuri
force-pushed
the
export-D64185644
branch
from
880e323 to
ab4c86a
Compare
avikchaudhuri
added a commit
to avikchaudhuri/pytorch
that referenced
this pull request
Oct 10, 2024
Summary: Pull Request resolved: pytorch#137705 Test Plan: fixed Reviewed By: tugsbayasgalan Differential Revision: D64185644
avikchaudhuri
force-pushed
the
export-D64185644
branch
from
ab4c86a to
0ea1b80
Compare
|
This pull request was exported from Phabricator. Differential Revision: D64185644 |
Summary: Pull Request resolved: pytorch#137705 Test Plan: fixed Reviewed By: tugsbayasgalan Differential Revision: D64185644
|
This pull request was exported from Phabricator. Differential Revision: D64185644 |
avikchaudhuri
force-pushed
the
export-D64185644
branch
from
0ea1b80 to
80ac69e
Compare
|
@pytorchbot merge -f 'Landed internally' (Initiating merge automatically since Phabricator Diff has merged, using force because this PR might not pass merge_rules.json but landed internally) |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ciflow/inductor
ciflow/trunk
Trigger trunk jobs on your pull request
fb-exported
Merged
release notes: AO frontend
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Test Plan: fixed
Differential Revision: D64185644