| CARVIEW |
Select Language
HTTP/2 200
date: Sat, 19 Jul 2025 11:19:05 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=417.642576,conversation_content-fragment;desc="conversation_content fragment";dur=1202.125329,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=265.145052,nginx;desc="NGINX";dur=1.422232,glb;desc="GLB";dur=96.013315
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: fd8fbbc
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=%2FvLNgzJwXOAGBiVCqJy6gCOCUgYmUSq95NT%2FDyEa0w3yKpa%2BauH4yga2Ag8Z28jepJajvhtVlROOKNok8PVVWIUJ39OUqNWtR7b0t5XaINAEQOnliljjqrKUzwD%2BNhqCPYKM6XLQP9C%2FxPCK3EBBiRKif%2FoYHDhXgpqLDbshmqsb3O26S4TLI9G%2Fq2vNMWk9ApjSL63WCSYJLR1nL9kiH7EVlLmm4DS75heGuHNEcmpalfc5UdLEZLtiVzRQ5ot6XxEINiFzWDTyRn9aPQxGMQ%3D%3D--Eg%2FhL0R%2Fjb%2FwpXaF--gldIi%2BDiUDyOMcR6Yf3wSA%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.727394742.1752923944; Path=/; Domain=github.com; Expires=Sun, 19 Jul 2026 11:19:04 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sun, 19 Jul 2026 11:19:04 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: E3FC:249704:40B8FE:51674E:687B7F28
[PyTorch] Port ExecuTorch bfdot improvement back to ATen BlasKernel, Try #2 by swolchok · Pull Request #137377 · pytorch/pytorch · GitHub
swolchok
added
release notes: performance_as_product
topic: performance
topic category
labels
Oct 4, 2024
swolchok
requested review from
albanD and
malfet
and removed request for
albanD
October 4, 2024 22:31
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 24.7k
[PyTorch] Port ExecuTorch bfdot improvement back to ATen BlasKernel, Try #2 #137377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Try #2 ExecuTorch's fork of BlasKernel.cpp grew bfdot support, complete with demonstration that it helps. Port it back to PyTorch. First attempt was #136331 . Differential Revision: [D63923166](https://our.internmc.facebook.com/intern/diff/D63923166/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/137377
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit fcb5288 with merge base de4c2a3 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
This pull request was exported from Phabricator. Differential Revision: D63923166 |
swolchok
added a commit
that referenced
this pull request
Oct 4, 2024
…Try #2 ExecuTorch's fork of BlasKernel.cpp grew bfdot support, complete with demonstration that it helps. Port it back to PyTorch. First attempt was #136331 . Differential Revision: [D63923166](https://our.internmc.facebook.com/intern/diff/D63923166/) ghstack-source-id: 246411194 Pull Request resolved: #137377
|
@pytorchbot label "ciflow/linux-aarch64" |
swolchok
added
release notes: performance_as_product
topic: performance
swolchok
requested review from
albanD and
malfet
and removed request for
albanD
…lasKernel, Try #2" ExecuTorch's fork of BlasKernel.cpp grew bfdot support, complete with demonstration that it helps. Port it back to PyTorch. First attempt was #136331 . Differential Revision: [D63923166](https://our.internmc.facebook.com/intern/diff/D63923166/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D63923166 |
…lasKernel, Try #2" ExecuTorch's fork of BlasKernel.cpp grew bfdot support, complete with demonstration that it helps. Port it back to PyTorch. First attempt was #136331 . Differential Revision: [D63923166](https://our.internmc.facebook.com/intern/diff/D63923166/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D63923166 |
swolchok
added a commit
that referenced
this pull request
Oct 7, 2024
…Try #2 Pull Request resolved: #137377 ExecuTorch's fork of BlasKernel.cpp grew bfdot support, complete with demonstration that it helps. Port it back to PyTorch. First attempt was #136331 . ghstack-source-id: 246616406 Differential Revision: [D63923166](https://our.internmc.facebook.com/intern/diff/D63923166/)
|
What's the difference with the previous attempt? |
swolchok
commented
Oct 8, 2024
aten/src/ATen/native/BlasKernel.cpp
Outdated
| } | ||
|
|
||
| // NOTE: The first attempt at landing BFDOT support with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@albanD here is the difference
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ho thanks for the pointer!
Should we undef DOT_WITH_FP32_ARITH_TAIL_AFTER_MAIN_LOOP_BODY ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is a .cpp file, so the macro isn't going to leak anywhere and it's not particularly necessary, but sure I can do that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
…lasKernel, Try #2" ExecuTorch's fork of BlasKernel.cpp grew bfdot support, complete with demonstration that it helps. Port it back to PyTorch. First attempt was #136331 . Differential Revision: [D63923166](https://our.internmc.facebook.com/intern/diff/D63923166/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D63923166 |
… back to ATen BlasKernel, Try #2" ExecuTorch's fork of BlasKernel.cpp grew bfdot support, complete with demonstration that it helps. Port it back to PyTorch. First attempt was #136331 . Differential Revision: [D63923166](https://our.internmc.facebook.com/intern/diff/D63923166/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D63923166 |
…Ten BlasKernel, Try #2" ExecuTorch's fork of BlasKernel.cpp grew bfdot support, complete with demonstration that it helps. Port it back to PyTorch. First attempt was #136331 . Differential Revision: [D63923166](https://our.internmc.facebook.com/intern/diff/D63923166/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D63923166 |
swolchok
added a commit
that referenced
this pull request
Oct 8, 2024
…Try #2 Pull Request resolved: #137377 ExecuTorch's fork of BlasKernel.cpp grew bfdot support, complete with demonstration that it helps. Port it back to PyTorch. First attempt was #136331 . ghstack-source-id: 246956192 Differential Revision: [D63923166](https://our.internmc.facebook.com/intern/diff/D63923166/)
|
CI is 100% green; please review |
…lasKernel, Try #2" ExecuTorch's fork of BlasKernel.cpp grew bfdot support, complete with demonstration that it helps. Port it back to PyTorch. First attempt was #136331 . Differential Revision: [D63923166](https://our.internmc.facebook.com/intern/diff/D63923166/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D63923166 |
malfet
approved these changes
Oct 10, 2024
|
If CI is green, than sure, LGTM |
This was referenced Oct 10, 2024
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ciflow/linux-aarch64
linux aarch64 CI workflow
ciflow/trunk
Trigger trunk jobs on your pull request
fb-exported
Merged
topic: performance
topic category
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Stack from ghstack (oldest at bottom):
defined(__aarch64__) && !defined(CPU_CAPABILITY_SVE256)instead ofdefined(CPU_CAPABILITY_NEON)#137722ExecuTorch's fork of BlasKernel.cpp grew bfdot support, complete with demonstration that it helps. Port it back to PyTorch. First attempt was #136331 .
Differential Revision: D63923166