| CARVIEW |
Select Language
HTTP/2 200
date: Sat, 19 Jul 2025 11:18:17 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=447.518371,conversation_content-fragment;desc="conversation_content fragment";dur=965.635308,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=429.236729,nginx;desc="NGINX";dur=1.455599,glb;desc="GLB";dur=95.563698
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: fd8fbbc
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=ZZu6Cm5QVpO3Te0ABWRJWHImkvTDH0CEG%2Bfo%2FGIHLKOSg4M5d8Xpx5r60ALXvufcVpEW2Q56T9QtBR0CSv0538vhlExc3zlfhLk6ww0Cs3VrrdtBS9QQ%2BkMMSnPgAN9cAMapjucQwvceLZp%2BYi6ALZdi5%2Fm1HLo4BeQG1OyOHKsOSPzfgv5m2xq%2FHkVptFwxOmDdMbzuKLUdmhbv9wskg%2FcVZJvp72xgJoYLwQanykz1eIbI%2BXojhHVz5rDFm%2BJ2vKl9gJ6Kf4f0kGzF3jv4AQ%3D%3D--XNZmaikwFXvEi46U--cJABSaDFzM1Fttt5iwxh0A%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.350544007.1752923896; Path=/; Domain=github.com; Expires=Sun, 19 Jul 2026 11:18:16 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sun, 19 Jul 2026 11:18:16 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: 9EE6:35CC93:22BEBE:2AC38A:687B7EF8
Fix triton_reshape to properly expand `Min` keyword in triton codegen by arui-meta · Pull Request #137357 · pytorch/pytorch · GitHub
Fix triton_reshape to properly expand
arui-meta
force-pushed
the
export-D63850158
branch
from
October 4, 2024 19:06
arui-meta
force-pushed
the
export-D63850158
branch
from
October 4, 2024 20:47
arui-meta
force-pushed
the
export-D63850158
branch
from
October 7, 2024 16:00
arui-meta
force-pushed
the
export-D63850158
branch
from
October 8, 2024 14:24
arui-meta
force-pushed
the
export-D63850158
branch
from
October 9, 2024 00:43
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 24.7k
Fix triton_reshape to properly expand Min keyword in triton codegen
#137357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/137357
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 2ce12ff with merge base 932b994 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
This pull request was exported from Phabricator. Differential Revision: D63850158 |
|
@pytorchbot label "topic: not user facing" |
arui-meta
force-pushed
the
export-D63850158
branch
from
da37a6d to
150f59c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D63850158 |
arui-meta
force-pushed
the
export-D63850158
branch
from
150f59c to
04f5710
Compare
arui-meta
added a commit
to arui-meta/pytorch
that referenced
this pull request
Oct 4, 2024
…ytorch#137357) Summary: Previously triton_reshape will generate code with `Min` keyword in it, which is incorrect. This diff updates the triton_reshape function to properly expand `Min` keyword to `<`. Test Plan: ``` buck2 run @//mode/{opt,mtia,inplace} //glow/fb/fx/fba/tests:test_fba_inductor -- -r test_Min_keyword_in_block_shape ``` Differential Revision: D63850158
|
This pull request was exported from Phabricator. Differential Revision: D63850158 |
arui-meta
force-pushed
the
export-D63850158
branch
from
04f5710 to
f5aa40e
Compare
arui-meta
added a commit
to arui-meta/pytorch
that referenced
this pull request
Oct 7, 2024
…ytorch#137357) Summary: Previously triton_reshape will generate code with `Min` keyword in it, which is incorrect. This diff updates the triton_reshape function to properly expand `Min` keyword to `<`. Test Plan: ``` buck2 run @//mode/{opt,inplace} fbcode//caffe2/test/inductor:torchinductor_strided_blocks -- -r test_complex_reshape_block_ptr ``` Differential Revision: D63850158
|
This pull request was exported from Phabricator. Differential Revision: D63850158 |
blaine-rister
approved these changes
Oct 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for the fix.
arui-meta
force-pushed
the
export-D63850158
branch
from
f5aa40e to
a9335b2
Compare
arui-meta
added a commit
to arui-meta/pytorch
that referenced
this pull request
Oct 8, 2024
…ytorch#137357) Summary: Previously triton_reshape will generate code with `Min` keyword in it, which is incorrect. This diff updates the triton_reshape function to properly expand `Min` keyword to `<`. Test Plan: ``` buck2 run @//mode/{opt,inplace} fbcode//caffe2/test/inductor:torchinductor_strided_blocks -- -r test_complex_reshape_block_ptr ``` Reviewed By: blaine-rister Differential Revision: D63850158
|
This pull request was exported from Phabricator. Differential Revision: D63850158 |
…ytorch#137357) Summary: Previously triton_reshape will generate code with `Min` keyword in it, which is incorrect. This diff updates the triton_reshape function to properly expand `Min` keyword to `<`. Test Plan: ``` buck2 run @//mode/{opt,inplace} fbcode//caffe2/test/inductor:torchinductor_strided_blocks -- -r test_complex_reshape_block_ptr ``` Reviewed By: blaine-rister Differential Revision: D63850158
arui-meta
force-pushed
the
export-D63850158
branch
from
a9335b2 to
2ce12ff
Compare
|
This pull request was exported from Phabricator. Differential Revision: D63850158 |
eellison
approved these changes
Oct 9, 2024
|
@pytorchbot merge -f 'Landed internally' (Initiating merge automatically since Phabricator Diff has merged, using force because this PR might not pass merge_rules.json but landed internally) |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ciflow/inductor
ciflow/trunk
Trigger trunk jobs on your pull request
fb-exported
Merged
module: inductor
topic: not user facing
topic category
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Summary: Previously triton_reshape will generate code with
Minkeyword in it, which is incorrect. This diff updates the triton_reshape function to properly expandMinkeyword to<.Test Plan:
Differential Revision: D63850158
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @desertfire @chauhang