You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For the reusable action checkout-pytorch, skips cleaning workspace when running from a container environment.
The motivation for this change is twofold:
There is no need for cleanup when running in ephemeral containers, as any changes will be discarded when the docker container is terminated;
In the specific case of GITHUB_WORKSPACE, to enable sharing this between multiple containers, it need to be mounted with -v. This prevents the possibility of running rm -r and deleting this mount path;
jeanschmidt
changed the title
Skip clean gha workspace if CI is running in a container for checkout-pytorch
[BE] Skip clean gha workspace if CI is running in a container for checkout-pytorch
Oct 2, 2024
jeanschmidt
changed the title
[BE] Skip clean gha workspace if CI is running in a container for checkout-pytorch
[BE] [CI] Skip clean gha workspace if CI is running in a container for checkout-pytorch
Oct 2, 2024
The reason will be displayed to describe this comment to others. Learn more.
The change LGTM code-wise but I am curious why cleaning up the local workspace needs to be skipped here. An explanation on the PR description would be great.
Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For the reusable action checkout-pytorch, skips cleaning workspace when running from a container environment.
The motivation for this change is twofold:
-v
. This prevents the possibility of runningrm -r
and deleting this mount path;