| CARVIEW |
Select Language
HTTP/2 200
date: Sat, 19 Jul 2025 11:26:37 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=335.748639,conversation_content-fragment;desc="conversation_content fragment";dur=1120.26287,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=343.540187,nginx;desc="NGINX";dur=1.23557,glb;desc="GLB";dur=95.350661
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: fd8fbbc
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=EoU%2FeCkI%2B%2BDW5oWUGkHlzbHc%2Bj%2FmjPtvfH6JNZEBQXtgpOi57CxHUgnLGgcPW2vZRxd0xBx9xbE1v416jqEqyXYN1aLFkFJMQwlNazk8d9TlHGkcgtJQt9UkdioOhSnMadzy7yL0z94XhNf5Y0F3%2FVEXw2G2A4ie0WdYlCAROL9dn8lOekoBy52rvyCrfvavMCgubu5L8pqiutk2aUo1C5w3C4dqaWSe7YgFyq2Rsfc04NU0L%2BRs427BEDL4%2BYyDXL4xXiykGPCFUhTV7YtDGg%3D%3D--kwLs2FpHGaVF9faF--lGtyJqUcRbj6uisgek4iFg%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1777638044.1752924396; Path=/; Domain=github.com; Expires=Sun, 19 Jul 2026 11:26:36 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sun, 19 Jul 2026 11:26:36 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: A4EC:134C64:6C9529:8EEDF3:687B80EC
[ONNX] Drop final None values as inputs for nodes in exporter graph by shubhambhokare1 · Pull Request #135520 · pytorch/pytorch · GitHub
shubhambhokare1
requested review from
titaiwangms,
justinchuby and
wschin
as code owners
September 9, 2024 19:06
pytorch-bot
bot
added
the
release notes: onnx
torch.onnx related changes that should show up in the release notes
label
Sep 9, 2024
shubhambhokare1
changed the title
[ONNX] Drop None values as inputs for nodes in exporter graph
[ONNX] Drop final None values as inputs for nodes in exporter graph
Sep 9, 2024
justinchuby
added
module: onnx
Related to torch.onnx
topic: bug fixes
topic category
and removed
ciflow/trunk
Trigger trunk jobs on your pull request
labels
Sep 9, 2024
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 24.7k
[ONNX] Drop final None values as inputs for nodes in exporter graph #135520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shubhambhokare1
requested review from
titaiwangms,
justinchuby and
wschin
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/135520
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (2 Unrelated Failures)As of commit 12635bc with merge base 5f7d956 ( BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
pytorch-bot
bot
added
the
release notes: onnx
shubhambhokare1
changed the title
justinchuby
reviewed
Sep 9, 2024
justinchuby
reviewed
Sep 9, 2024
justinchuby
approved these changes
Sep 9, 2024
|
@pytorchbot merge |
justinchuby
added
module: onnx
|
The release was cut: https://github.com/pytorch/pytorch/commits/release/2.5/ This may need cherry-picking @shubhambhokare1 |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
justinchuby
added a commit
to justinchuby/torch-onnx
that referenced
this pull request
Sep 9, 2024
justinchuby
added a commit
to justinchuby/torch-onnx
that referenced
this pull request
Sep 9, 2024
shubhambhokare1
added a commit
to shubhambhokare1/pytorch
that referenced
this pull request
Sep 17, 2024
…ytorch#135520) When value for an optional input is not provided, it is defaulted to `None`, which gets translates to "" in the onnx graph. To avoid this, if we have a list of inputs and the final few are all `None`, strip them in the graph. Pull Request resolved: pytorch#135520 Approved by: https://github.com/justinchuby Co-authored-by: Justin Chu <justinchuby@users.noreply.github.com> (cherry picked from commit e2f9a83)
This was referenced Sep 17, 2024
Chao1Han
pushed a commit
to Chao1Han/pytorch
that referenced
this pull request
Sep 20, 2024
…ytorch#135520) When value for an optional input is not provided, it is defaulted to `None`, which gets translates to "" in the onnx graph. To avoid this, if we have a list of inputs and the final few are all `None`, strip them in the graph. Pull Request resolved: pytorch#135520 Approved by: https://github.com/justinchuby Co-authored-by: Justin Chu <justinchuby@users.noreply.github.com>
kit1980
pushed a commit
that referenced
this pull request
Sep 20, 2024
…d Drop final None values as inputs for nodes in exporter graph (#135520) (#136005) * [ONNX] Update fake mode usage in onnx docs (#135512) Update fake mode usage in onnx docs Pull Request resolved: #135512 Approved by: https://github.com/justinchuby Co-authored-by: Justin Chu <justinchuby@users.noreply.github.com> (cherry picked from commit 66db61f) * [ONNX] Drop final None values as inputs for nodes in exporter graph (#135520) When value for an optional input is not provided, it is defaulted to `None`, which gets translates to "" in the onnx graph. To avoid this, if we have a list of inputs and the final few are all `None`, strip them in the graph. Pull Request resolved: #135520 Approved by: https://github.com/justinchuby Co-authored-by: Justin Chu <justinchuby@users.noreply.github.com> (cherry picked from commit e2f9a83)
56 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Merged
module: onnx
Related to torch.onnx
open source
release notes: onnx
torch.onnx related changes that should show up in the release notes
topic: bug fixes
topic category
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
When value for an optional input is not provided, it is defaulted to
None, which gets translates to "" in the onnx graph. To avoid this, if we have a list of inputs and the final few are allNone, strip them in the graph.