| CARVIEW |
Navigation Menu
-
Notifications
You must be signed in to change notification settings - Fork 24.7k
[CI] Fix update slow tests #135390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Fix update slow tests #135390
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/135390
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
| mandatory_checks_name: | ||
| - EasyCLA | ||
| - Lint | ||
| - pull |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also - slow?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any idea why trunk isn't part of most of these rules?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think trunk used to mean only jobs running in trunk, not PR. Then we make it running as part of merge process, so it's not here.
| @@ -204,5 +213,6 @@ def search_for_open_pr( | |||
| # no existing pr, so make a new one and approve it | |||
| pr_num = make_pr("pytorch/pytorch", params) | |||
| time.sleep(5) | |||
| add_labels("pytorch/pytorch", pr_num, ["ciflow/slow", "ci-no-td"]) | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alternatively, you could update titleRegexToLabel in https://github.com/pytorch/test-infra/blob/main/torchci/lib/bot/autoLabelBot.ts#L19 to add these labels. I think that would be cleaner than writing another add_labels function here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I'd prefer to leave it here in order to keep everything in one place
| mandatory_checks_name: | ||
| - EasyCLA | ||
| - Lint | ||
| - pull |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any idea why trunk isn't part of most of these rules?
|
@pytorchbot merge -f "no trunk needed" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
* Add pytorchbot to list of approvers for file * Add labels to the auto created PR The auto generated PR is currently not merging due to some failing tests on slow workflow that were supposed to be moved back to normal idk if this has much value, clearly we've been managing without the update Pull Request resolved: pytorch#135390 Approved by: https://github.com/ZainRizvi
The auto generated PR is currently not merging due to some failing tests on slow workflow that were supposed to be moved back to normal
idk if this has much value, clearly we've been managing without the update