| CARVIEW |
Select Language
HTTP/2 200
date: Sat, 19 Jul 2025 11:15:05 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=406.540129,conversation_content-fragment;desc="conversation_content fragment";dur=1159.800905,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=378.592822,nginx;desc="NGINX";dur=0.906557,glb;desc="GLB";dur=94.978484
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: fd8fbbc
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=kcTATchkaymTwoKhVLSZQtE4hL5WvRwCjg%2FrdEO2xdOTNMyBAzbWMnvfpZT6oufGB6qV5Aa6HYSNvI5RB3Nuz%2FlyM%2BzB1sI%2F6NRXFktZxR9ulfltX4xZ11rsa0w9GX4KVDBYAihlSGUdHTxp6554ciwIBK2V76P3lscZaOEsK%2BFTPEcri8JkzmiJ52rtMku44LXdEGdZ1exkNnqzTvnGeY4lGBOcxJYE7u2Fhtm3n0EOI4sUtGWI9ezvTIOALxkspbdyx5GVtyaftSPbwj5J5A%3D%3D--MHStR4YiauGoctRA--qRJEgTT2WRMsIkI%2Fwy%2Bxlg%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.715691304.1752923704; Path=/; Domain=github.com; Expires=Sun, 19 Jul 2026 11:15:04 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sun, 19 Jul 2026 11:15:04 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: AFD2:0A55:38364B:459CA7:687B7E38
Add missing input "eps" to adam docs by Sunishchal · Pull Request #135191 · pytorch/pytorch · GitHub
soulitzer
added
the
triaged
This issue has been looked at a team member, and triaged and prioritized into an appropriate module
label
Sep 6, 2024
pytorchmergebot
force-pushed
the
patch-1
branch
from
September 25, 2024 15:51
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 24.7k
Add missing input "eps" to adam docs #135191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/135191
Note: Links to docs will display an error until the docs builds have been completed. âś… No FailuresAs of commit b432ec4 with merge base 780f4de ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
janeyx99
reviewed
Sep 5, 2024
torch/optim/adam.py
Outdated
| @@ -253,7 +253,8 @@ def step(self, closure=None): | |||
| \begin{aligned} | |||
| &\rule{110mm}{0.4pt} \\ | |||
| &\textbf{input} : \gamma \text{ (lr)}, \beta_1, \beta_2 | |||
| \text{ (betas)},\theta_0 \text{ (params)},f(\theta) \text{ (objective)} \\ | |||
| \text{ (betas)},\theta_0 \text{ (params)},f(\theta) \text{ (objective)} | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you move this to after the maximize?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also include a docs preview when you get the chance?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @janeyx99 I've made the requested change. Just waiting for approval on the CI pipeline before the docs update. Here is the docs preview on the original version of the PR.
soulitzer
added
the
triaged
janeyx99
approved these changes
Sep 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
|
Sorry I've been busy the weeks up to the conference, only catching up on notifs now. Thanks for the edit! @pytorchbot merge -r |
|
@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here |
|
Successfully rebased |
pytorchmergebot
force-pushed
the
patch-1
branch
from
2a1c7b0 to
b432ec4
Compare
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
BoyuanFeng
pushed a commit
to BoyuanFeng/pytorch
that referenced
this pull request
Sep 25, 2024
Minor fix for missing input argument in the Adam optimizer docs page. Pull Request resolved: pytorch#135191 Approved by: https://github.com/janeyx99
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ciflow/trunk
Trigger trunk jobs on your pull request
Merged
open source
release notes: optim
triaged
This issue has been looked at a team member, and triaged and prioritized into an appropriate module
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Minor fix for missing input argument in the Adam optimizer docs page.