mod_pubsub: Don't blindly echo PEP notification

weiss · weiss · commit 3469a51f5896 · 2024-09-13T20:50:00.000+02:00
Since commit 514c25c, whenever a PEP item was published, a notification was blindly sent back to the owner. However, this should only be done subject to +notify filtering, as per XEP-0163: | the PEP service shall send notifications to all of the account owner's | available resources (subject to notification filtering). The motivation for the mentioned commit was that +notify subscriptions initially didn't work for PEP node owners (#2108). However, that issue was fixed by commit 5968bc9 (#2112). As a result, the owner's client was actually notified twice if the client was subscribed to the node (e.g., via +notify). Therefore, just omit the additional, blind notification. Thanks to W. Martin Borgert and Daniel Gultsch for reporting the issue.
diff --git a/src/mod_pubsub.erl b/src/mod_pubsub.erl
@@ -3052,9 +3052,7 @@ broadcast_stanza({LUser, LServer, LResource}, Publisher, Node, Nidx, Type, NodeO
 	       extended_headers([Publisher])),
     Pred = fun(To) -> delivery_permitted(Owner, To, NodeOptions) end,
     ejabberd_sm:route(jid:make(LUser, LServer, SenderResource),
-		      {pep_message, <<((Node))/binary, "+notify">>, Stanza, Pred}),
-    ejabberd_router:route(xmpp:set_to(xmpp:put_meta(Stanza, ignore_sm_bounce, true),
-		                      jid:make(LUser, LServer)));
+		      {pep_message, <<((Node))/binary, "+notify">>, Stanza, Pred});
 broadcast_stanza(Host, _Publisher, Node, Nidx, Type, NodeOptions, SubsByDepth, NotifyType, BaseStanza, SHIM) ->
     broadcast_stanza(Host, Node, Nidx, Type, NodeOptions, SubsByDepth, NotifyType, BaseStanza, SHIM).
 
