CARVIEW |
Select Language
HTTP/2 200
date: Thu, 31 Jul 2025 11:24:42 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com wss://alive-staging.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=710.639311,conversation_content-fragment;desc="conversation_content fragment";dur=995.265664,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=411.932472,nginx;desc="NGINX";dur=1.488127,glb;desc="GLB";dur=100.61421
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: 321f992
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=gBAQnGxpS0MPh7ZeWdRIdwVz7KIeie6CJQ89y%2F0rwk9ptYHb%2BMbxSnIJVTMyu8y8s8hHapjMjgOtk2TeUdBPT%2FkhJx4K5DuV0spPkBZuqKx1bOl6SMRAOpjNKXEFMGzgPeEt476MyyVccO0illBt9kKbBWUuDKycg6njGY%2BuORX1PUUX8lrydXb%2FbBjWysd8XWX70jh77VeDlVpqwyeApIpIaA083Q%2F01eDo96Qw2TdoI7E8mF3IDIcXgD754SZE9HhKWt7BXvHd893m255E1w%3D%3D--vgzOwWYyjP9bIVcB--sc9j4DFw7iPAibFJEoaAjQ%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.761325471.1753961081; Path=/; Domain=github.com; Expires=Fri, 31 Jul 2026 11:24:41 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Fri, 31 Jul 2026 11:24:41 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: C4C0:21A23A:90F489:AD53DE:688B5279
Add `Bindable<T>.CopyTo` and use in `GetUnboundCopy` implementation by peppy · Pull Request #5531 · ppy/osu-framework · GitHub
Add
peppy
force-pushed
the
get-unbound-copy-optimisation
branch
3 times, most recently
from
November 22, 2022 04:48
peppy
force-pushed
the
get-unbound-copy-optimisation
branch
from
November 22, 2022 04:51
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 442
Add Bindable<T>.CopyTo
and use in GetUnboundCopy
implementation
#5531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a35029f
to
3f1722d
Compare
3f1722d
to
0750864
Compare
smoogipoo
requested changes
Nov 22, 2022
osu! side changes required: peppy/osu@1632df1 Seems to work okay. |
Co-authored-by: Dan Balasescu <smoogipoo@smgi.me>
smoogipoo
approved these changes
Nov 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
This method is used heavily in
AudioAdjustments
, which is how I got here.osu-framework/osu.Framework/Audio/AudioAdjustments.cs
Line 68 in ba13853
Breaking Changes
Bindable<T>.CopyTo
should be implemented for any custom bindablesTo improve the performance of creating clones of bindables (ie. via
GetUnboundCopy()
), the copy portion ofBindTo()
has been split out into its own method. If you have any custom bindable types which were copying values across within aBindTo()
override, please move the copy operation toCopyTo()
instead. Pay special attention to the direction of assignment, which will reverse from what it was inBindTo
.A fix should look something like this: