Fix for respecting rule levels for property.nameNotString

ondrejmirtes · ondrejmirtes · commit 81a8d3495d76 · 2025-07-21T15:19:48.000+02:00
diff --git a/src/Rules/Properties/AccessPropertiesCheck.php b/src/Rules/Properties/AccessPropertiesCheck.php
@@ -62,10 +62,16 @@ public function check(PropertyFetch $node, Scope $scope, bool $write): array
 					$scope,
 					$node->name,
 					'',
-					static fn (Type $type) => $type->toString()->isString()->yes(),
+					static fn (Type $type) => !$type->toString() instanceof ErrorType && $type->toString()->isString()->yes(),
 				);
 				$nameType = $nameTypeResult->getType();
-				if ($nameType instanceof ErrorType || $nameType->toString() instanceof ErrorType || !$nameType->toString()->isString()->yes()) {
+				if (
+					!$nameType instanceof ErrorType
+					&& (
+						$nameType->toString() instanceof ErrorType
+						|| !$nameType->toString()->isString()->yes()
+					)
+				) {
 					$originalNameType = $scope->getType($node->name);
 					$className = $scope->getType($node->var)->describe(VerbosityLevel::typeOnly());
 					$errors[] = RuleErrorBuilder::message(sprintf('Property name for %s must be a string, but %s was given.', $className, $originalNameType->describe(VerbosityLevel::precise())))
diff --git a/tests/PHPStan/Rules/Properties/AccessPropertiesRuleTest.php b/tests/PHPStan/Rules/Properties/AccessPropertiesRuleTest.php
@@ -996,10 +996,6 @@ public function testDynamicStringableAccess(): void
 				'Property name for $this(DynamicStringableAccess\Foo) must be a string, but $this(DynamicStringableAccess\Foo) was given.',
 				16,
 			],
-			[
-				'Property name for $this(DynamicStringableAccess\Foo) must be a string, but object was given.',
-				17,
-			],
 			[
 				'Property name for $this(DynamicStringableAccess\Foo) must be a string, but array was given.',
 				18,
@@ -1013,10 +1009,6 @@ public function testDynamicStringableAccess(): void
 				'Property name for DynamicStringableAccess\Foo must be a string, but $this(DynamicStringableAccess\Foo) was given.',
 				31,
 			],
-			[
-				'Property name for $this(DynamicStringableAccess\Foo) must be a string, but object was given.',
-				32,
-			],
 		]);
 	}
 
@@ -1044,10 +1036,6 @@ public function testDynamicStringableNullsafeAccess(): void
 				'Property name for $this(DynamicStringableNullsafeAccess\Foo) must be a string, but $this(DynamicStringableNullsafeAccess\Foo) was given.',
 				16,
 			],
-			[
-				'Property name for $this(DynamicStringableNullsafeAccess\Foo) must be a string, but object was given.',
-				17,
-			],
 		]);
 	}
 
@@ -1100,4 +1088,20 @@ public function testPropertyExists(): void
 		$this->analyse([__DIR__ . '/data/property-exists.php'], []);
 	}
 
+	public function testDiscussion13274(): void
+	{
+		$this->checkThisOnly = false;
+		$this->checkUnionTypes = true;
+		$this->checkDynamicProperties = true;
+		$this->analyse([__DIR__ . '/data/discussion-13274.php'], []);
+	}
+
+	public function testBug4117(): void
+	{
+		$this->checkThisOnly = false;
+		$this->checkUnionTypes = true;
+		$this->checkDynamicProperties = true;
+		$this->analyse([__DIR__ . '/data/bug-4117.php'], []);
+	}
+
 }
diff --git a/tests/PHPStan/Rules/Properties/data/bug-4117.php b/tests/PHPStan/Rules/Properties/data/bug-4117.php
@@ -0,0 +1,15 @@
+<?php
+
+declare(strict_types = 1);
+
+namespace Bug4117;
+
+function (): void {
+	$object = new class{
+		public string $example_one = "";
+		public string $example_two = "";
+	};
+
+	$field = rand() > 0.5 ? 'example_one' : 'example_two';
+	$result = $object->$field;
+};
diff --git a/tests/PHPStan/Rules/Properties/data/discussion-13274.php b/tests/PHPStan/Rules/Properties/data/discussion-13274.php
@@ -0,0 +1,12 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Discussion13274;
+
+class A {}
+
+$a = new A;
+
+/** @var mixed $foo */
+$a->{$foo} = 'bar';
