Introduce phpstan-deprecation-rules

staabm · web-flow · commit 0f857bfcea0d · 2025-03-18T10:49:50.000+01:00
diff --git a/composer.json b/composer.json
@@ -14,6 +14,7 @@
 	},
 	"require-dev": {
 		"php-parallel-lint/php-parallel-lint": "^1.2",
+		"phpstan/phpstan-deprecation-rules": "^2.0",
 		"phpstan/phpstan-strict-rules": "^2.0",
 		"phpunit/phpunit": "^9.6"
 	},
diff --git a/phpstan.neon b/phpstan.neon
@@ -2,6 +2,7 @@ includes:
 	- extension.neon
 	- rules.neon
 	- vendor/phpstan/phpstan-strict-rules/rules.neon
+	- vendor/phpstan/phpstan-deprecation-rules/rules.neon
 	- phar://phpstan.phar/conf/bleedingEdge.neon
 	- phpstan-baseline.neon
 
diff --git a/src/Rules/PHPUnit/ClassCoversExistsRule.php b/src/Rules/PHPUnit/ClassCoversExistsRule.php
@@ -50,7 +50,7 @@ public function processNode(Node $node, Scope $scope): array
 	{
 		$classReflection = $node->getClassReflection();
 
-		if (!$classReflection->isSubclassOf(TestCase::class)) {
+		if (!$classReflection->is(TestCase::class)) {
 			return [];
 		}
 
diff --git a/src/Rules/PHPUnit/ClassMethodCoversExistsRule.php b/src/Rules/PHPUnit/ClassMethodCoversExistsRule.php
@@ -56,7 +56,7 @@ public function processNode(Node $node, Scope $scope): array
 			return [];
 		}
 
-		if (!$classReflection->isSubclassOf(TestCase::class)) {
+		if (!$classReflection->is(TestCase::class)) {
 			return [];
 		}
 
diff --git a/src/Rules/PHPUnit/DataProviderDeclarationRule.php b/src/Rules/PHPUnit/DataProviderDeclarationRule.php
@@ -52,7 +52,7 @@ public function processNode(Node $node, Scope $scope): array
 	{
 		$classReflection = $scope->getClassReflection();
 
-		if ($classReflection === null || !$classReflection->isSubclassOf(TestCase::class)) {
+		if ($classReflection === null || !$classReflection->is(TestCase::class)) {
 			return [];
 		}
 
diff --git a/src/Rules/PHPUnit/DataProviderHelper.php b/src/Rules/PHPUnit/DataProviderHelper.php
@@ -76,7 +76,7 @@ public function getDataProviderMethods(
 				}
 
 				$dataProviderMethod = $this->parseDataProviderAnnotationValue($scope, $dataProviderValue);
-				$dataProviderMethod[] = $node->getLine();
+				$dataProviderMethod[] = $node->getStartLine();
 
 				yield $dataProviderValue => $dataProviderMethod;
 			}
@@ -257,7 +257,7 @@ private function parseDataProviderExternalAttribute(Attribute $attribute): ?arra
 			sprintf('%s::%s', $className, $methodNameArg->value) => [
 				$dataProviderClassReflection,
 				$methodNameArg->value,
-				$attribute->getLine(),
+				$attribute->getStartLine(),
 			],
 		];
 	}
@@ -279,7 +279,7 @@ private function parseDataProviderAttribute(Attribute $attribute, ClassReflectio
 			$methodNameArg->value => [
 				$classReflection,
 				$methodNameArg->value,
-				$attribute->getLine(),
+				$attribute->getStartLine(),
 			],
 		];
 	}
diff --git a/src/Rules/PHPUnit/NoMissingSpaceInClassAnnotationRule.php b/src/Rules/PHPUnit/NoMissingSpaceInClassAnnotationRule.php
@@ -33,7 +33,7 @@ public function getNodeType(): string
 	public function processNode(Node $node, Scope $scope): array
 	{
 		$classReflection = $scope->getClassReflection();
-		if ($classReflection === null || $classReflection->isSubclassOf(TestCase::class) === false) {
+		if ($classReflection === null || $classReflection->is(TestCase::class) === false) {
 			return [];
 		}
 
diff --git a/src/Rules/PHPUnit/NoMissingSpaceInMethodAnnotationRule.php b/src/Rules/PHPUnit/NoMissingSpaceInMethodAnnotationRule.php
@@ -33,7 +33,7 @@ public function getNodeType(): string
 	public function processNode(Node $node, Scope $scope): array
 	{
 		$classReflection = $scope->getClassReflection();
-		if ($classReflection === null || $classReflection->isSubclassOf(TestCase::class) === false) {
+		if ($classReflection === null || $classReflection->is(TestCase::class) === false) {
 			return [];
 		}
 
diff --git a/src/Rules/PHPUnit/ShouldCallParentMethodsRule.php b/src/Rules/PHPUnit/ShouldCallParentMethodsRule.php
@@ -33,7 +33,7 @@ public function processNode(Node $node, Scope $scope): array
 			return [];
 		}
 
-		if (!$scope->getClassReflection()->isSubclassOf(TestCase::class)) {
+		if (!$scope->getClassReflection()->is(TestCase::class)) {
 			return [];
 		}
 

Original file line number	Diff line number	Diff line change
`@@ -50,7 +50,7 @@ public function processNode(Node $node, Scope $scope): array`
`50`	`50`	`{`
`51`	`51`	`$classReflection = $node->getClassReflection();`
`52`	`52`
`53`		`- if (!$classReflection->isSubclassOf(TestCase::class)) {`
	`53`	`+ if (!$classReflection->is(TestCase::class)) {`
`54`	`54`	`return [];`
`55`	`55`	`}`
`56`	`56`
Original file line number	Diff line number	Diff line change
`@@ -56,7 +56,7 @@ public function processNode(Node $node, Scope $scope): array`
`56`	`56`	`return [];`
`57`	`57`	`}`
`58`	`58`
`59`		`- if (!$classReflection->isSubclassOf(TestCase::class)) {`
	`59`	`+ if (!$classReflection->is(TestCase::class)) {`
`60`	`60`	`return [];`
`61`	`61`	`}`
`62`	`62`
Original file line number	Diff line number	Diff line change
`@@ -52,7 +52,7 @@ public function processNode(Node $node, Scope $scope): array`
`52`	`52`	`{`
`53`	`53`	`$classReflection = $scope->getClassReflection();`
`54`	`54`
`55`		`- if ($classReflection === null \|\| !$classReflection->isSubclassOf(TestCase::class)) {`
	`55`	`+ if ($classReflection === null \|\| !$classReflection->is(TestCase::class)) {`
`56`	`56`	`return [];`
`57`	`57`	`}`
`58`	`58`
Original file line number	Diff line number	Diff line change
`@@ -76,7 +76,7 @@ public function getDataProviderMethods(`
`76`	`76`	`}`
`77`	`77`
`78`	`78`	`$dataProviderMethod = $this->parseDataProviderAnnotationValue($scope, $dataProviderValue);`
`79`		`- $dataProviderMethod[] = $node->getLine();`
	`79`	`+ $dataProviderMethod[] = $node->getStartLine();`
`80`	`80`
`81`	`81`	`yield $dataProviderValue => $dataProviderMethod;`
`82`	`82`	`}`
`@@ -257,7 +257,7 @@ private function parseDataProviderExternalAttribute(Attribute $attribute): ?arra`
`257`	`257`	`sprintf('%s::%s', $className, $methodNameArg->value) => [`
`258`	`258`	`$dataProviderClassReflection,`
`259`	`259`	`$methodNameArg->value,`
`260`		`- $attribute->getLine(),`
	`260`	`+ $attribute->getStartLine(),`
`261`	`261`	`],`
`262`	`262`	`];`
`263`	`263`	`}`
`@@ -279,7 +279,7 @@ private function parseDataProviderAttribute(Attribute $attribute, ClassReflectio`
`279`	`279`	`$methodNameArg->value => [`
`280`	`280`	`$classReflection,`
`281`	`281`	`$methodNameArg->value,`
`282`		`- $attribute->getLine(),`
	`282`	`+ $attribute->getStartLine(),`
`283`	`283`	`],`
`284`	`284`	`];`
`285`	`285`	`}`
Original file line number	Diff line number	Diff line change
`@@ -33,7 +33,7 @@ public function getNodeType(): string`
`33`	`33`	`public function processNode(Node $node, Scope $scope): array`
`34`	`34`	`{`
`35`	`35`	`$classReflection = $scope->getClassReflection();`
`36`		`- if ($classReflection === null \|\| $classReflection->isSubclassOf(TestCase::class) === false) {`
	`36`	`+ if ($classReflection === null \|\| $classReflection->is(TestCase::class) === false) {`
`37`	`37`	`return [];`
`38`	`38`	`}`
`39`	`39`
Original file line number	Diff line number	Diff line change
`@@ -33,7 +33,7 @@ public function processNode(Node $node, Scope $scope): array`
`33`	`33`	`return [];`
`34`	`34`	`}`
`35`	`35`
`36`		`- if (!$scope->getClassReflection()->isSubclassOf(TestCase::class)) {`
	`36`	`+ if (!$scope->getClassReflection()->is(TestCase::class)) {`
`37`	`37`	`return [];`
`38`	`38`	`}`
`39`	`39`