CARVIEW |
Select Language
HTTP/2 200
date: Wed, 23 Jul 2025 03:02:01 GMT
content-type: text/html; charset=utf-8
cache-control: max-age=0, private, must-revalidate
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
link: ; rel=preload; as=fetch; crossorigin=use-credentials
referrer-policy: no-referrer-when-downgrade
server-timing: issue_layout-fragment;desc="issue_layout fragment";dur=264.363739,issue_conversation_content-fragment;desc="issue_conversation_content fragment";dur=2109.629521,issue_conversation_sidebar-fragment;desc="issue_conversation_sidebar fragment";dur=42.496618,nginx;desc="NGINX";dur=1.524246,glb;desc="GLB";dur=101.969238
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With, Accept,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: fd8fbbc
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=H9C1rheXZ%2F0DEbtyVXG%2Bzg%2BA751zS8MVvvFIeW43LF8oqqZ75QKYtOFLGjCumETYvWIJDXCkLJOMqtBSBQgV7hkjwdHU%2FCEUjQKoB02y12QshWteEUVm5r2RpW%2F1NR0HkCRqAkVBFpcjKi3pZGR%2FNot5ybFkxuD7bF8x%2BK%2FzSL7XVBwPYzQfc5FBDA2veL73NLHoBRu2IQrZx5C8az52XHPnjdcc730j4xhafrqRsD3xfu1ghIHnJwG8WTBLMQ%2F8ND32yvwEzEnoEJsEysRpxA%3D%3D--za0hiLmoJWQ%2FpMjN--s4TDr%2BzmKb0juV71Y0xCZQ%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.2145696888.1753239718; Path=/; Domain=github.com; Expires=Thu, 23 Jul 2026 03:01:58 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Thu, 23 Jul 2026 03:01:58 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: D912:26221E:29DC03:3B2CC1:688050A6
analyze "@override" in phpdoc of methods · Issue #926 · phan/phan · GitHub
No one assignedNo typeNo projectsNo milestoneNone yetNo branches or pull requests
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 371
Closed
Labels
enhancementThis improves the quality of Phan's analysis of a codebaseThis improves the quality of Phan's analysis of a codebase
Description
https://github.com/phpDocumentor/fig-standards doesn't have any issues mentioning @override
, so there's nothing to base this off of
class SubClass extends BaseClass {
/**
* @override
*/
public function myMethod(){}
}
Proposed semantics:
- If there's a concrete or abstract method in a base class, trait, or interface, then phan should not emit an issue
- For magic method such as __call(), __set_state(), don't warn
- If there's a phpdoc
@method
but no real methods, emit a different warning about intended semantics? - Otherwise, warn
also,
- warn if used in an abstract method or a method declared in an interface
- Support
@phan-override
as well, since the semantics may end up being specific to phan and other tools may disagree.
Metadata
Metadata
Assignees
Labels
enhancementThis improves the quality of Phan's analysis of a codebaseThis improves the quality of Phan's analysis of a codebase
Type
Projects
Milestone
Relationships
Development
Issue actions
You can’t perform that action at this time.