You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
using nginx conf of last version, IN app/src/infrastructure/Translations.js the setLangBasedOnDomainMiddleware would get the req.headers.host as 127.0.0.1:3000 not the domain. and this leads to the failing multi-languages support.
To Reproduce, make a clean install with multi-languages settings, add the following log commant to the file app/src/infrastructure/Translations.js, and restart the container:
constlogger=require('logger-sharelatex')functionsetLangBasedOnDomainMiddleware(req,res,next){// Determine language from subdomainconstlang=availableHosts.get(req.headers.host)if(lang){req.i18n.changeLanguage(lang)}// add this line !!!!!!!logger.log(`host: ${req.headers.host}, lang: ${lang}`)// expose the language code to pugres.locals.currentLngCode=req.language// If the set language is different from the language detection (based on// the Accept-Language header), then set flag which will show a banner// offering to switch to the appropriate libraryconstdetectedLanguageCode=headerLangDetector.detect(req,res)if(req.language!==detectedLanguageCode){res.locals.suggestedLanguageSubdomainConfig=subdomainConfigs.get(detectedLanguageCode)}// Decorate req.i18n with translate function alias for backwards// compatibility usage in requestsreq.i18n.translate=req.i18n.tnext()}
Many thanks @RainshawGao , I see the issue with Host header regarding i18n. Did you spot any problem requiring X-Real-IP and REMOTE-HOST to be included?
Thanks for the PR. I would lean toward including only the headers we know are required, i.e. just Host, as per #896 (comment). So, @RainshawGao , yes, I think if you remove those that would be preferred.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
using nginx conf of last version, IN
app/src/infrastructure/Translations.js
thesetLangBasedOnDomainMiddleware
would get thereq.headers.host
as127.0.0.1:3000
not the domain. and this leads to the failing multi-languages support.To Reproduce, make a clean install with multi-languages settings, add the following log commant to the file
app/src/infrastructure/Translations.js
, and restart the container:and in the log of web, we can see this:
with this fix, the log would be:
Contributor Agreement