@orta Still some work to do on event properties, and I'm curious about this block to retrieve properties you mentioned earlier. I'm turning in, but I'd love to hear your thoughts on where this is so far.

So I'd imagine to cover the 90% of use cases I'd start with the DSL:

    [ 
      @{
        ARAnalyticsEvent: @"opened_box",
        ARAnalyticsClass: ARMyViewController.class,
        ARAnalyticsSelector: @keypath(ARMyViewController.new, boxOpened),
        ARAnalyticsEventProperties: NSDictionary *^(ARMyViewController *controller) {
            return @{ @"opened" : @(controller.isOpened) };
        },
        ARAnalyticsShouldFire: BOOL ^(ARMyViewController *controller) {
            return controller.hasChangedState;
        }
      },
      {...}]

( This was how we built the ARNavigationButtonsViewController )

I like this DSL a lot. Implementing now.

Hrm. Can't store SEL pointers directly in dictionaries. Going to fall back to storing them in strings for now.

OK I've got it to a place I feel happy with. Going to start integrating it into the Artsy app and see if I run into any problems.

OK, I have no idea what's going on here. Any ideas anyone?

@ashfurrow try merging in (or rebasing off of) ARAnalytics/heapFix ... this looks to be the cause: https://travis-ci.org/orta/ARAnalytics/builds/24325829#L1199

I think @confidenceJuice's suggestion should do it, also, don't forget to add to the CHANGELOG & README

Righto – merged in and updating CHANGELOG & README.

CI is still failing, despite working locally.

rage. To be fair the fail on it: 0) Write auxiliary files (https://travis-ci.org/orta/ARAnalytics/builds/24345382#L1480) is one I have experienced randomly/ un reproducibly when building on command line

💥

Super! I've created a new version in the CHANGELOG. Should I update the version number in the podspec before we merge?

yeh why not, also in chagelog :

• New DSL for analytics => New DSL for analytics (thanks @AshFurrow)
• Updated Head support (thanks @confidenceJuice) => Updated Heap support (thanks @confidenceJuice)

Haha – oops, sorry for the typo. I'll get it fixed.

Say, this was just released and could replace our reliance on ReactiveCocoa and RSSwizzle. I'm going to investigate switching over.

Alright, let's get this PR merged, we don't need to do a release yet ( I'd rather the @steipete stuff gets in before that ) but this gives people a chance to try it.

@kylef dictionaries like this tends to be a pattern we use internally, would definitely be interested in adding some functions that returns a dictionary providing some stronger typing there 👍

also, thanks for the massive contribution @ashfurrow

Cool. The AOP stuff will change the public interface slightly (NSArray of parameters instead of RACTuples), but that shouldn't be too hard to migrate.