CARVIEW |
Navigation Menu
Fix cross-organisation "Allow edits from maintainers" #5634
Replies: 22 comments · 9 replies
-
You might want to change the title to match the exact option name -allow edit by maintainer
+Allow edits from maintainers I just filed #9921 because I was not able to find this issue before |
Beta Was this translation helpful? Give feedback.
All reactions
-
π 1
-
Interestingly the documentation shows a screenshot that is "Allow edits from maintainers", but I just did the same thing on a personal pull request and it shows "Allow edits by maintainers |
Beta Was this translation helpful? Give feedback.
All reactions
-
Moving over feedback from #9921 Personally, I do not see a reason for "Allow edits from maintainers" to have a different behavior if the pull request is coming from a organization. If you think otherwise and it's working as intended then please explicitly state what's the official decision regarding this behavior. This is blocking some commit-automation-based tools from working as intended, as reported in isaacs/github#1681 (comment) |
Beta Was this translation helpful? Give feedback.
All reactions
-
π 3
-
I would assume the reason is that organisation accounts have different and more complex collaboration models so not breaking anything is probably riskier, and furthermore orgs are commonly companies which may not want "unmanaged" / "stealth" contributors of that fashion. Not that that makes this limitation any less of a pain, mind. But it's not hard to imagine why it would be. |
Beta Was this translation helpful? Give feedback.
All reactions
-
This is increasingly becoming an issue for pull requests to outside projects from forks inside our Org. I concur with @joao-paulo-parity opinion. If there is a technical limitation causing this option to be missing, we would like an explanation and clearer documentation as to the difference between Org and user created forks in respect to this option's availability. Is there a simple work around in the meantime? Can commits be added directly to a pull request by the maintainer if they are added to our fork as an outside collaborator? It's not an ideal solution if so, but may help with the issues we are experiencing while making contributions. |
Beta Was this translation helpful? Give feedback.
All reactions
-
Yes IIRC if the maintainer is added as a collaborator to the repository they'll get whatever access you grant them. But that can be rather distasteful as the "write" access level (necessary for pushing code to the repository) also provides write access to a lot of meta-information which you may not want to grant to the maintainer on the other side. Though I guess it's less of an issue when it comes to forks. |
Beta Was this translation helpful? Give feedback.
All reactions
-
π 1
-
This is still an issue. I use an organization account in order to keep my forked repos separate from my main projects, so I'm always making PRs from an organization account. There have been several times I wanted to allow edits from maintainers, but was unable to find the option. |
Beta Was this translation helpful? Give feedback.
All reactions
-
Same exact use-case and problem here. |
Beta Was this translation helpful? Give feedback.
All reactions
-
π 4 -
π 3
-
IS there any update to this issue? we got same use-case and problem here |
Beta Was this translation helpful? Give feedback.
All reactions
-
π 1 -
π 1
-
Same problem, nobody can commit to my forks, I keep them in an org for separation. |
Beta Was this translation helpful? Give feedback.
All reactions
-
π 1 -
π 1
-
still a problem :( |
Beta Was this translation helpful? Give feedback.
All reactions
-
π 2 -
π 1
-
This is still an issue. |
Beta Was this translation helpful? Give feedback.
All reactions
-
π 1 -
π 1
-
HELP! Please fix this, or we shall move to svn π₯² |
Beta Was this translation helpful? Give feedback.
All reactions
-
π 2 -
π 1 -
π 5
-
help |
Beta Was this translation helpful? Give feedback.
All reactions
-
Hello, We have the same issue in our Combodo/iTop repo. Some of our contributors are employees of companies that are Combodo partners, so they are using forks in their employer org and won't create forks in their personal account... I understand a repo in an organization is shared with more people than just personal repo... Maybe add org to org authorizations ? Like in the previous example, allow Combodo/iTop maintainers to have access to Itomig fork during a day ? |
Beta Was this translation helpful? Give feedback.
All reactions
-
This seems to still be an issue and is limiting organization's ability to contribute to open source projects, example pull-request here. |
Beta Was this translation helpful? Give feedback.
All reactions
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
-
Still a issue and waiting for something to be done about this |
Beta Was this translation helpful? Give feedback.
All reactions
-
If "edit from maintainers" isn't an option for PR submitters, consider adding "block PRs from organizations" for repo owners. Receiving PRs without the ability to collaborate is frustrating, and repeatedly explaining the issue is a time-waster. |
Beta Was this translation helpful? Give feedback.
All reactions
-
π 8 -
π 1
-
WOW -- still an issue. Anyway -- if it's not going to be changed, then at least put some prominent text on there, so I doin't spend who knows how long looking desperately for the check box! Maybe, in place of the check box: "Allowing edits from maintiners is not allows for org accounts' or SOMETHING!! |
Beta Was this translation helpful? Give feedback.
All reactions
-
π 12
-
Great idea, I just did the same thing this morning, looking at the PR from all aspects, looking through repo settings, etc. Also, mentioning this in the docs would be a great idea! |
Beta Was this translation helpful? Give feedback.
All reactions
-
I think this is also affecting forks of org forks, even if the resulting fork don't live in an organization. Which is quite confusing for new users. Example: littlefs-project/littlefs#1013 |
Beta Was this translation helpful? Give feedback.
All reactions
-
Another example of this: openwrt/openwrt#16779 (comment). In my case I'm using an org because I have multiple forks of a project for collaborating across different feature sets (hardware in the case of OpenWRT), and I'm unable to keep multiple forks without an organization :/ |
Beta Was this translation helpful? Give feedback.
All reactions
-
I also bumped on this after I made a script to clean up my forks They have to understand and accept. Some of them decline to join my fork write write permission, but they complain about not being able to push on my fork. EDIT: So, yes I also need a solution for organization PR |
Beta Was this translation helpful? Give feedback.
All reactions
-
@ccoVeille I'd be very cautious about that, write permission could lead to unexpected incidents, e.g. if your fork has billable resources or "unexpected" content in your repo could bring you legal problems. Consider also that you're trusting other repo maintainers not to have their account hacked, which could affect you too. Check this table https://docs.github.com/en/organizations/managing-user-access-to-your-organizations-repositories/managing-repository-roles/repository-roles-for-an-organization |
Beta Was this translation helpful? Give feedback.
All reactions
-
π 2
-
Very wise warning. I will reconsider the way I do. I don't think I can onboard people automagically. |
Beta Was this translation helpful? Give feedback.
All reactions
-
This is still an issue in 2025. Others have pointed out that there are architectural and security reasons why this wouldn't be trivial to do by default for organizations, which is very fair. However, it would be really nice if this behavior was more clearly signaled on Pull Requests: I have 3-4 conversations a month on Pull Requests where the other maintainer is (reasonably) confused and frustrated because they can't make suggestions or push to my branch, and they typically assume it's a configuration problem (i.e. my fault) instead of GitHub's own limitation. To that end, even just a small warning on the Pull Request's sidebar explaining that organization forks don't support suggestions or edits from upstream maintainers would go a long way. |
Beta Was this translation helpful? Give feedback.
All reactions
-
π 8 -
β€οΈ 1 -
π 1
-
Agree, even if the design does not support it temporarily, the restricted situations should be marked otherwise it is too painful to explain repeatedly. |
Beta Was this translation helpful? Give feedback.
All reactions
-
π 2
-
Hm interesting. I just crashed into this, and now we need to move our changes from org fork to my for, which takes little bit time, at least when you already create PR already... I mean, is there any solution, on lets say: I have org, we have team and we are using opensource, but, in opensource there is a bug, so our team will create fix (of course in our org fork as it makes sense?) and then what? Somebody then need to manually push that branch to someone's personal fork? I mean... this sounds stupid, or am I stupid? |
Beta Was this translation helpful? Give feedback.
All reactions
-
π 1
-
An idea that could work is if GitHub would give org admins a way to assign an "allow edits" permission to certain trusted members. |
Beta Was this translation helpful? Give feedback.
All reactions
-
π 1
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
(aka "Allow edits by maintainers")
Currently, if a PR is created from a fork living under an organisation (rather than an individual) it's not possible to allow edits by maintainers. This is better than the previous state of affairs where the feature was available but did not work, but it remains less than great.
Cf isaacs/github#1681 for a long list of maintainers mentioning exactly this issue on dozens of PRs (which probably undercounts the issue by orders of magnitude as they'd need to know about the informal isaacs tracker).
Beta Was this translation helpful? Give feedback.
All reactions