CARVIEW |
Navigation Menu
-
-
Notifications
You must be signed in to change notification settings - Fork 56.2k
G-API: Fix incorrect OpaqueKind for Kernel outputs #23843
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
G-API: Fix incorrect OpaqueKind for Kernel outputs #23843
Conversation
pkg = cv.gapi.kernels(GSquareMeanImpl) | ||
mean, squares = comp.apply(cv.gin([1,2,3]), args=cv.gapi.compile_args(pkg)) | ||
|
||
self.assertEqual([1,4,9], list(squares)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@asmorkalov @opencv-alalek I'm a little bit confused why we convert std::vector<T>
to python tuple
instead of list
?
https://github.com/opencv/opencv/blob/4.x/modules/python/src2/cv2_convert.hpp#L359-L362
@dmatveev Could you have a look, please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Fantastic, thanks for the quick turn-around!!!
Probably a short problem description would still make sense - for historic reasons..
@@ -46,6 +46,7 @@ G desync(const G &g) { | |||
, {cv::detail::GTypeTraits<G>::shape} // output Shape | |||
, {cv::detail::GTypeTraits<G>::op_kind} // input data kinds | |||
, {cv::detail::GObtainCtor<G>::get()} // output template ctors | |||
, {cv::detail::GTypeTraits<G>::op_kind} // output data kinds |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
, {cv::detail::GTypeTraits<G>::op_kind} // output data kinds | |
, {cv::detail::GTypeTraits<G>::op_kind} // output data kind |
Co-authored-by: Dmitry Matveev <dmm1989@gmail.com>
Co-authored-by: Dmitry Matveev <dmm1989@gmail.com>
…aque-kind-for-kernel G-API: Fix incorrect OpaqueKind for Kernel outputs opencv#23843 ### Pull Request Readiness Checklist #### Overview The PR is going to fix several problems: 1. Major: `GKernel` doesn't hold `kind` for its outputs. Since `GModelBuilder` traverse graph from outputs to inputs once it reaches any output of the operation it will use its `kind` to create `Data` meta for all operation outputs. Since it essential for `python` to know `GTypeInfo` (which is `shape` and `kind`) it will be confused. Consider this operation: ``` @cv.gapi.op('custom.square_mean', in_types=[cv.GArray.Int], out_types=[cv.GOpaque.Float, cv.GArray.Int]) class GSquareMean: @staticmethod def outMeta(desc): return cv.empty_gopaque_desc(), cv.empty_array_desc() ``` Even though `GOpaque` is `Float`, corresponding metadata might have `Int` kind because it might be taken from `cv.GArray.Int` so it will be a problem if one of the outputs of these operation is graph output because python will cast it to the wrong type based on `Data` meta. 2. Minor: Some of the OpenVINO `IR`'s doesn't any layout information for input. It's usually true only for `IRv10` but since `OpenVINO 2.0` need this information to correctly configure resize we need to put default layout if there no such assigned in `ov::Model`. See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request - [ ] I agree to contribute to the project under Apache 2 License. - [ ] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV - [ ] The PR is proposed to the proper branch - [ ] There is a reference to the original bug report and related work - [ ] There is accuracy test, performance test and test data in opencv_extra repository, if applicable Patch to opencv_extra has the same branch name. - [ ] The feature is well documented and sample code can be built with the project CMake
…aque-kind-for-kernel G-API: Fix incorrect OpaqueKind for Kernel outputs opencv#23843 ### Pull Request Readiness Checklist #### Overview The PR is going to fix several problems: 1. Major: `GKernel` doesn't hold `kind` for its outputs. Since `GModelBuilder` traverse graph from outputs to inputs once it reaches any output of the operation it will use its `kind` to create `Data` meta for all operation outputs. Since it essential for `python` to know `GTypeInfo` (which is `shape` and `kind`) it will be confused. Consider this operation: ``` @cv.gapi.op('custom.square_mean', in_types=[cv.GArray.Int], out_types=[cv.GOpaque.Float, cv.GArray.Int]) class GSquareMean: @staticmethod def outMeta(desc): return cv.empty_gopaque_desc(), cv.empty_array_desc() ``` Even though `GOpaque` is `Float`, corresponding metadata might have `Int` kind because it might be taken from `cv.GArray.Int` so it will be a problem if one of the outputs of these operation is graph output because python will cast it to the wrong type based on `Data` meta. 2. Minor: Some of the OpenVINO `IR`'s doesn't any layout information for input. It's usually true only for `IRv10` but since `OpenVINO 2.0` need this information to correctly configure resize we need to put default layout if there no such assigned in `ov::Model`. See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request - [ ] I agree to contribute to the project under Apache 2 License. - [ ] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV - [ ] The PR is proposed to the proper branch - [ ] There is a reference to the original bug report and related work - [ ] There is accuracy test, performance test and test data in opencv_extra repository, if applicable Patch to opencv_extra has the same branch name. - [ ] The feature is well documented and sample code can be built with the project CMake
Pull Request Readiness Checklist
Overview
The PR is going to fix several problems:
GKernel
doesn't holdkind
for its outputs. SinceGModelBuilder
traverse graph from outputs to inputs once it reaches any output of the operation it will use itskind
to createData
meta for all operation outputs. Since it essential forpython
to knowGTypeInfo
(which isshape
andkind
) it will be confused.Consider this operation:
Even though
GOpaque
isFloat
, corresponding metadata might haveInt
kind because it might be taken fromcv.GArray.Int
so it will be a problem if one of the outputs of these operation is graph output because python will cast it to the wrong type based on
Data
meta.IR
's doesn't any layout information for input. It's usually true only forIRv10
but sinceOpenVINO 2.0
need this information to correctly configure resize we need to put default layout if there no such assigned inov::Model
.See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.