| CARVIEW |
Select Language
HTTP/2 200
date: Mon, 21 Jul 2025 11:22:47 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=435.782854,conversation_content-fragment;desc="conversation_content fragment";dur=1251.525975,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=355.660961,nginx;desc="NGINX";dur=1.087386,glb;desc="GLB";dur=95.13049
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: fd8fbbc
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=9tOBVCgKRNwaJXqNGdn1GeOzjqJIiJGhSr4AiUQZfuYIXGN0%2FJ%2BBf1kLCGDsoBFfqnSafBsKLnKyQe99IwnzIgNoTvrd9rsZNjjsk%2BD%2BvIeHB7kBa0aarJabHZih5uPW56HWA2yTKKa9n2RcJuJ2p8b1SmgAYs7ORLNq%2B1PRQnBhNrtlZEGRI7nPiTMQRgPTBkc9CYRM8EsFYf2YWXvKof6MgGNzyNjTGKlrwblDC%2F%2FHF88hZgDVmxl1Eylzx7Qd6Qj56%2BRK%2FgePYy0JPqajCQ%3D%3D--%2FRRrQYQDbMtBK2Ci--9MlA7Ut4D1%2BrLE9d8Qfwew%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1394199317.1753096965; Path=/; Domain=github.com; Expires=Tue, 21 Jul 2026 11:22:45 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Tue, 21 Jul 2026 11:22:45 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: B6CE:0A87:1A898E3:214A5DB:687E2305
Support ONNX operator QLinearSoftmax in dnn by fengyuentau · Pull Request #23655 · opencv/opencv · GitHub
fengyuentau
added
optimization
category: dnn
category: dnn (onnx)
ONNX suport issues in DNN module
labels
May 22, 2023
asmorkalov
changed the title
dnn: support ONNX operator QLinearSoftmax
WIP: support ONNX operator QLinearSoftmax in dnn
May 23, 2023
fengyuentau
changed the title
WIP: support ONNX operator QLinearSoftmax in dnn
Support ONNX operator QLinearSoftmax in dnn
May 24, 2023
Skip to content
Navigation Menu
{{ message }}
-
-
Notifications
You must be signed in to change notification settings - Fork 56.2k
Support ONNX operator QLinearSoftmax in dnn #23655
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fengyuentau
added
optimization
category: dnn
category: dnn (onnx)
asmorkalov
reviewed
May 22, 2023
asmorkalov
changed the title
dkurt
reviewed
May 23, 2023
dkurt
reviewed
May 23, 2023
| TEST_P(Test_ONNX_layers, QLinearSoftmax) | ||
| { | ||
| // threshold is set for fusion with dequantization | ||
| testONNXModels("qlinearsoftmax_11", npy, 0.001, 0.002); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this test cover all 4 scenarios?
SoftmaxInt8Invoker<true>::run(src, dst, blobs[0], N, D, output_sc, output_zp);
SoftmaxInt8Invoker<false>::run(src, dst, blobs[0], N, D, output_sc, output_zp);
SoftmaxInt8OutputFloatInvoker<true>::run(src, dst, blobs[0], N, D);
SoftmaxInt8OutputFloatInvoker<false>::run(src, dst, blobs[0], N, D);There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test does not cover log softmax, but it is tested by the existing test Test_Int8_layers.Softmax_log_ONNX/0 instead.
The model architecture of this test is like [input]->QuantizeLinear -> QLinearSoftmax -> DequantizeLinear -> [output]. Since we have tryFuse in SoftmaxInt8 which fuses DequantizeLinear and therefore we have output in float instead of int8 in the end, SoftmaxInt8OutputFloatInvoker<false>::run(...) is triggered here in the test. I tested locally with tryFuse disabled which triggers SoftmaxInt8Invoker<false>::run(...) and it passes. Do you think it necessary to add another test case for int8 output like [input] -> QLinearSoftmax -> [output]?
fengyuentau
changed the title
|
All todo items are clear. Please review if possible. |
zihaomu
reviewed
May 25, 2023
zihaomu
approved these changes
May 25, 2023
dkurt
approved these changes
May 25, 2023
Merged
thewoz
pushed a commit
to thewoz/opencv
that referenced
this pull request
Jan 4, 2024
Support ONNX operator QLinearSoftmax in dnn opencv#23655 Resolves opencv#23636. Merge with opencv/opencv_extra#1064. This PR maps the QLinearSoftmax (from com.microsoft domain) to SoftmaxInt8 in dnn along with some speed optimization. Todo: - [x] support QLinearSoftmax with opset = 13 - [x] add model and test data for QLinearSoftmax with opset = 13 - [x] ensure all models have dims >= 3. - [x] add the script to generate model and test data ### Pull Request Readiness Checklist See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request - [x] I agree to contribute to the project under Apache 2 License. - [x] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV - [x] The PR is proposed to the proper branch - [x] There is a reference to the original bug report and related work - [x] There is accuracy test, performance test and test data in opencv_extra repository, if applicable Patch to opencv_extra has the same branch name. - [x] The feature is well documented and sample code can be built with the project CMake
48 tasks
thewoz
pushed a commit
to thewoz/opencv
that referenced
this pull request
May 29, 2024
Support ONNX operator QLinearSoftmax in dnn opencv#23655 Resolves opencv#23636. Merge with opencv/opencv_extra#1064. This PR maps the QLinearSoftmax (from com.microsoft domain) to SoftmaxInt8 in dnn along with some speed optimization. Todo: - [x] support QLinearSoftmax with opset = 13 - [x] add model and test data for QLinearSoftmax with opset = 13 - [x] ensure all models have dims >= 3. - [x] add the script to generate model and test data ### Pull Request Readiness Checklist See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request - [x] I agree to contribute to the project under Apache 2 License. - [x] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV - [x] The PR is proposed to the proper branch - [x] There is a reference to the original bug report and related work - [x] There is accuracy test, performance test and test data in opencv_extra repository, if applicable Patch to opencv_extra has the same branch name. - [x] The feature is well documented and sample code can be built with the project CMake
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Resolves #23636.
Merge with opencv/opencv_extra#1064.
This PR maps the QLinearSoftmax (from com.microsoft domain) to SoftmaxInt8 in dnn along with some speed optimization.
Todo:
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.