| CARVIEW |
Select Language
HTTP/2 200
date: Mon, 21 Jul 2025 02:32:49 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=384.22944,conversation_content-fragment;desc="conversation_content fragment";dur=729.309735,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=268.133577,nginx;desc="NGINX";dur=1.025933,glb;desc="GLB";dur=95.366953
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: fd8fbbc
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=p2kcYAVGQ3oNhr8ltin97qnJHAiLS5untciUuC6p9JazaTHYmMbQiamaRmLk6PtK5qYwlPY5rGSYRc9ZWn9Bq%2FGEG%2FEfz%2F0fTlcvmxQP%2FU40MWrH06FezCh5%2FjlL%2FiQXEjooNxcag91aYElckz5BLrQyrBvR0bU9gwLUUSnyD4q2%2ByC0Dcm0Z2mlS0SBnu6mGRXVIG9hBICJzwx6hDxNv2tc9IT2gTepvsIg47gznfjdfm55qirh2nszmBNvGTnN3jzEQch3Z1yMxF8anvkpSg%3D%3D--vpiBofuNxQWoRw7P--fW1pQH5lqijB%2BZpGQQ1YGA%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.2096683785.1753065169; Path=/; Domain=github.com; Expires=Tue, 21 Jul 2026 02:32:49 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Tue, 21 Jul 2026 02:32:49 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: ED0A:0A55:FD89A9:14C4F41:687DA6D1
GAPI FLUID: Enable dynamic dispatching for Merge3 by alexgiving · Pull Request #21529 · opencv/opencv · GitHub
alexgiving
force-pushed
the
atrutnev/simd_for_merge3
branch
from
February 1, 2022 10:45
Skip to content
Navigation Menu
{{ message }}
-
-
Notifications
You must be signed in to change notification settings - Fork 56.2k
GAPI FLUID: Enable dynamic dispatching for Merge3 #21529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
opencv-pushbot
merged 1 commit into
opencv:4.x
from
alexgiving:atrutnev/simd_for_merge3
Feb 16, 2022
Merged
GAPI FLUID: Enable dynamic dispatching for Merge3 #21529
opencv-pushbot
merged 1 commit into
opencv:4.x
from
alexgiving:atrutnev/simd_for_merge3
Feb 16, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexgiving
force-pushed
the
atrutnev/simd_for_merge3
branch
from
9def428 to
c623676
Compare
anna-khakimova
approved these changes
Feb 16, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
đź‘Ť
alalek
reviewed
Feb 16, 2022
Comment on lines
+2512
to
+2515
| const auto *in = src.InLine<uchar>(0); | ||
| auto *out1 = dst1.OutLine<uchar>(); | ||
| auto *out2 = dst2.OutLine<uchar>(); | ||
| auto *out3 = dst3.OutLine<uchar>(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no sense with aligning of in and out variables. They still stay unaligned. Just because they are from the different groups.
IMHO, we should not have unrelated changes in the patch. Code for review should be clear and should follow the purposes in PRs description.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That PR is included in cascade of optimization PRs. In previous one #21520 (comment) the alignment was changed and in this PR returned to be the same as in other kernels
dmatveev
approved these changes
Feb 16, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Merge3 SIMD.xlsx
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.