You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I agree to contribute to the project under Apache 2 License.
To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
The PR is proposed to proper branch
There is reference to original bug report and related work
There is accuracy test, performance test and test data in opencv_extra repository, if applicable
Patch to opencv_extra has the same branch name.
The feature is well documented and sample code can be built with the project CMake
Pull Request Description
This pull request improves Connected Components Labeling functions as it follows:
Introduces the 4-way connectivity version of Spaghetti (Spaghetti4C), generated with the tool described in Bolelli, F., Allegretti, S., & Grana, C. (2021). One DAG to Rule Them All. IEEE Transactions on Pattern Analysis and Machine Intelligence.
Introduces the parallel implementation of Spaghetti and Spaghetti4C algorithms.
Improves regression tests introducing the validation of corner cases, like chessboard images, single row and single column images, etc.
Changes the default algorithm to the current state of the art.
The reason will be displayed to describe this comment to others. Learn more.
It is better to split scenarios on dedicated tests cases.
It is extremely useful to debug scenario in the middle (through test filtering instead of passing code).
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.
Pull Request Description
This pull request improves Connected Components Labeling functions as it follows: