empty result is valid in case when video stream is longer than audio.

empty result is valid in case when video stream is longer than audio.

Within the framework of this functionality, such a case is not possible. I think this case should be considered separately by adding an additional condition when will audio + video support be implemented.

Anyway this error criteria is not correct. And the error handling above in "default:".

We just forget to change that properly (our testdata doesn't handle such cases).

We can remove this outdated docstring

return EOL back.

Don't introduce unnecessary whitespace changes.

return EOL back.

Don't introduce unnecessary whitespace changes.

Sorry, I do not quite understand what this is about

Do you see changed code here? - yes
Is it indented and necessary change? - no

Then revert it.

(0,i)

Just (i).
.at(i) is agnostic to vector-rows or vector-cols.

This logic is not correct. Checks must be "index"-based.

What is the problem to write correct logic once instead of rewriting them again with adding video support?

Anyway this error criteria is not correct. And the error handling above in "default:".

We just forget to change that properly (our testdata doesn't handle such cases).

missing the error message about unsupported format.

2 data copies are happened here.
We should avoid that to keep OpenCV effective library.

Use:

• dst.create()
• data = dst.getMat()
• fill data

First 2 calls could be done outside of switch for successful path.