| CARVIEW |
Select Language
HTTP/2 200
date: Mon, 21 Jul 2025 23:51:52 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=273.601592,conversation_content-fragment;desc="conversation_content fragment";dur=647.429867,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=232.573355,nginx;desc="NGINX";dur=0.925102,glb;desc="GLB";dur=102.006096
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: fd8fbbc
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=F5AzlQdyFMR0B9PZDjfQwLCIZcqcGspfSRV5fCdfbkISCwQQkXsfrUp6wCqMkp4x64lrdk77Y9wO9xe2cEJTYWvdvLKMElkHrRr%2FtLXw09vqJaU0TotaQfveSKKGTS%2FBfKCQC0gt6KMM7wQZv6GFVaGz3h8T82Sn9F%2BVFgyJlb%2BB9RAGPRKOBFayHD35pS1I4qupCwYV%2FewXiq7fRjfVCoH%2FQ6%2BynjRJa5Sgom6RIs6tNTqSICbCEqOw5dALeC1286k7WdeSWD33ZadAGpGUUw%3D%3D--IUusvR3PUU4UhUad--WtYfiUWL%2FyC95qdMmpFZ7g%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.526379815.1753141911; Path=/; Domain=github.com; Expires=Tue, 21 Jul 2026 23:51:51 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Tue, 21 Jul 2026 23:51:51 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: C806:2CB368:EE2E3:1640C8:687ED297
GAPI Fluid: Resize Linear U8C3 - reworking horizontal pass. by anna-khakimova · Pull Request #21144 · opencv/opencv · GitHub
anna-khakimova
force-pushed
the
ak/resize_simd_v2
branch
from
January 12, 2022 13:31
anna-khakimova
force-pushed
the
ak/resize_simd_v2
branch
from
January 12, 2022 13:50
Skip to content
Navigation Menu
{{ message }}
-
-
Notifications
You must be signed in to change notification settings - Fork 56.2k
GAPI Fluid: Resize Linear U8C3 - reworking horizontal pass. #21144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anna-khakimova
force-pushed
the
ak/resize_simd_v2
branch
from
6bf90aa to
000588b
Compare
anna-khakimova
force-pushed
the
ak/resize_simd_v2
branch
from
000588b to
52f38b6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm sorry - looks like i'm not the right person who eligible to review intrisics code so deeply.
@anna-khakimova you had better to add the more qualified reviewer then me.
I was expected to find differences in buffer tail processing conditions, but it seems on much more modifications here. Sorry again - I'm not enough qualified for reviewing such strong SSE code
| @@ -216,8 +216,8 @@ CV_ALWAYS_INLINE void calcRowLinear_8UC_Impl_<3>(uint8_t* dst[], | |||
| const int lpi) { | |||
| bool xRatioEq = inSz.width == outSz.width; | |||
| bool yRatioEq = inSz.height == outSz.height; | |||
| constexpr int nlanes = 16; | |||
| constexpr int half_nlanes = 16 / 2; | |||
| constexpr int nlanes = 16; // number of 8-bit integers that fit into a 128-bit SIMD vector. | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggest to make code self documented ( may be in future ways) likes as
struct sse_traits {
constexpr int instruction_size = 128;
constexpr int lanes_count = 128 / 8bit;
...
}
and reuse them
|
|
||
| for (int x = 0; outSz.width >= nlanes; ) | ||
| __m128i horizontal_shuf_mask1 = _mm_setr_epi8(0, 1, 2, 4, 5, 6, 8, 9, 10, 12, 13, 14, 3, 7, 11, 15); | ||
| constexpr int nproc_pixels = 5; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is nproc_pixels: is it non_proc or number of proc and how is 5 was obtained?
UPDATE: discussed offline.
but i still think that processing_pixel_number looks better
5 = 128 / 24, where 24 is rgb * 8bit - could you please put it into comment?
sivanov-work
approved these changes
Jan 14, 2022
6 tasks
Merged
a-sajjad72
pushed a commit
to a-sajjad72/opencv
that referenced
this pull request
Mar 30, 2023
GAPI Fluid: Resize Linear U8C3 - reworking horizontal pass. * Reworked horizontal pass * Fixed valgrind issue and removed unnesesary snippet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Reworking the Resize Linear U8C3 horizontal pass. Previous version handles 16 pixels per loop iteration. New version handles 5 pixels per iteration.
Fix for valgrind issue
Enabling SSE41 SIMD Resize U8C3
Valgrind run ( âś– failed due to
GAPI_Streaming_Desync.Python_Pull_Overloadhang/timeout - reproducible on weekly builds)Performance report:
Resize8uc3NewHorizontal.xlsx