| CARVIEW |
Select Language
HTTP/2 200
date: Mon, 21 Jul 2025 16:00:36 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=344.285291,conversation_content-fragment;desc="conversation_content fragment";dur=1322.364966,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=294.711007,nginx;desc="NGINX";dur=1.525658,glb;desc="GLB";dur=95.802724
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: fd8fbbc
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=JnmPLKhVAKZAzmwn6ID4n5jUIUeDie%2BtsVYwUZG9vVxHNFkJT3Psrpod2hyT%2BVycYX9CTafqyoOtpXLvZlJb9hiTm3Zwx5jMRCVu0y4T0HW5Ai9M4Jc2KaAirXADHpKRhwXpYi8%2BWg35jErUeNMOF4BdZYXTWvYR7HXyQ2XhbMSVZUsWM1IfuNnapmjxkEXpG78Au4EJysBFKsh1RS4hI6Ya%2BUsYeweSR8Ol2DM66dX4bhTZanJENC6tNiA3AWgYOSfr16gOmIywXb6Q0SjE%2Fw%3D%3D--RJzU0mwTO90JlUcf--EXUBKkCBTGOBNUIuSUKHZw%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1278619463.1753113635; Path=/; Domain=github.com; Expires=Tue, 21 Jul 2026 16:00:35 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Tue, 21 Jul 2026 16:00:35 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: 9598:37440E:B7764:D66E5:687E6423
[G-API] Support postprocessing for not argmaxed outputs by TolyaTalamanov · Pull Request #20476 · opencv/opencv · GitHub
Skip to content
Navigation Menu
{{ message }}
-
-
Notifications
You must be signed in to change notification settings - Fork 56.2k
[G-API] Support postprocessing for not argmaxed outputs #20476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
alalek
merged 7 commits into
opencv:master
from
TolyaTalamanov:at/support-unet-camvid-0001-segm-sample
Aug 6, 2021
Merged
[G-API] Support postprocessing for not argmaxed outputs #20476
alalek
merged 7 commits into
opencv:master
from
TolyaTalamanov:at/support-unet-camvid-0001-segm-sample
Aug 6, 2021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TolyaTalamanov
commented
Jul 29, 2021
* Add static_cast to uint8_t
mpashchenkov
approved these changes
Aug 2, 2021
|
@dmatveev Could you have a look ? |
dmatveev
approved these changes
Aug 4, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM if the existing case is not broken with this change.
Comment on lines
+51
to
+69
| void classesToColors(const cv::Mat &out_blob, | ||
| cv::Mat &mask_img) { | ||
| const int H = out_blob.size[0]; | ||
| const int W = out_blob.size[1]; | ||
|
|
||
| mask_img.create(H, W, CV_8UC3); | ||
| GAPI_Assert(out_blob.type() == CV_8UC1); | ||
| const uint8_t* const classes = out_blob.ptr<uint8_t>(); | ||
|
|
||
| for (int rowId = 0; rowId < H; ++rowId) { | ||
| for (int colId = 0; colId < W; ++colId) { | ||
| uint8_t class_id = classes[rowId * W + colId]; | ||
| mask_img.at<cv::Vec3b>(rowId, colId) = | ||
| class_id < colors.size() | ||
| ? colors[class_id] | ||
| : cv::Vec3b{0, 0, 0}; // NB: sample supports 20 classes | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this be expressed with our graph operators? Just wondering
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mean call this function inside the user kernel ? Or express this algo by using already existing operations ?
Comment on lines
+121
to
123
| cv::resize(mask_img, out, in.size()); | ||
| const float blending = 0.3f; | ||
| out = in * blending + out * (1 - blending); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can this be moved on the graph level, too? Not critical to do it right now but worth considering for the future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On the graph level cv::Size parameter is unknown, isn't it ?
It's obviously can be custom resize operation
Comment on lines
+109
to
+110
| // NB: If output has more than single plane, it contains probabilities | ||
| // otherwise class id. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this robust enough? Maybe explicit enum flag is better? I just don't know.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you mean by enum flag ? In that case you need to match model name with postprocessing enum flag, right ?
I don't think that it's a great solution, just tried not to overdesign it.
|
@alalek Can it be merged ? |
Merged
a-sajjad72
pushed a commit
to a-sajjad72/opencv
that referenced
this pull request
Mar 30, 2023
…amvid-0001-segm-sample [G-API] Support postprocessing for not argmaxed outputs * Support postprocessing for not argmaxed outputs * Fix typo * Add assert * Remove static cast * CamelCast to snake_case * Fix windows warning * Add static_cast to uint8_t * Add const to variables
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.
Overview
Some semantic segmentation networks such as unet-camvid-0001 from OMZ produce multi-plane output (1 x num_classesx H x W). In that case need to perform argmax operation for every pixel through channel plane in order to convert output to 1 x 1 x H x W representation where every pixel is class id.
Build configuration