[G-API] Support RMat for PlaidML backend #19782

TolyaTalamanov · 2021-03-25T14:55:58Z

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

I agree to contribute to the project under Apache 2 License.
To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
The PR is proposed to proper branch
There is reference to original bug report and related work
There is accuracy test, performance test and test data in opencv_extra repository, if applicable
Patch to opencv_extra has the same branch name.
The feature is well documented and sample code can be built with the project CMake

Build configuration

Xforce_builders_only=linux,docs
force_builders=Custom,Custom Win,Custom Mac
build_gapi_standalone:Linux x64=ade-0.1.1f
build_gapi_standalone:Win64=ade-0.1.1f
build_gapi_standalone:Mac=ade-0.1.1f
build_gapi_standalone:Linux x64 Debug=ade-0.1.1f
Xbuild_image:Custom=centos:7
Xbuildworker:Custom=linux-1
build_gapi_standalone:Custom=ade-0.1.1f
build_image:Custom Win=openvino-2021.1.0
build_image:Custom Mac=openvino-2021.2.0
test_modules:Custom=gapi,python2,python3,java
test_modules:Custom Win=gapi,python2,python3,java
test_modules:Custom Mac=gapi,python2,python3,java
buildworker:Custom=linux-1
# disabled due high memory usage: test_opencl:Custom=ON
test_opencl:Custom=OFF
Xtest_bigdata:Custom=1
Xtest_filter:Custom=*
Xforce_builders=Custom
Xbuildworker:Custom=linux-1
build_image:Custom=plaidml2
Xtest_modules:Custom=gapi
test_filter:Custom=*ML*

dmatveev

@rgarnov do we have any other backends with an issue like this or this backend just didn't use magazine which "hides" this new detail?

dmatveev · 2021-03-25T18:01:05Z

modules/gapi/src/backends/plaidml/gplaidmlbackend.cpp

        switch (arg.index())
        {
-        case GRunArg::index_of<cv::Mat>() :
+        case GRunArg::index_of<cv::RMat>():
        {
-            auto& arg_mat = util::get<cv::Mat>(arg);
-            binder_->input(it->second).copy_from(arg_mat.data);
+            auto& rmat = cv::util::get<cv::RMat>(arg);
+            auto  view = rmat.access(cv::RMat::Access::R);
+            auto  mat  = cv::gimpl::asMat(view);
+            binder_->input(it->second).copy_from(mat.data);
        }


@rgarnov shouldn't this happen by default? I thought it is

It's done in default magazine::bindInArg. Default magazine is not used in plaidml backend and I think it's not worth to bring it here. So current changes are good

TolyaTalamanov · 2021-03-25T19:57:36Z

@alalek

According log PlaidML wasn't found

[----------] 1 test from GAPI_PlaidML_Pipelines
[ RUN      ] GAPI_PlaidML_Pipelines.ThrowIfPlaidMLNotFound
[       OK ] GAPI_PlaidML_Pipelines.ThrowIfPlaidMLNotFound (0 ms)
[----------] 1 test from GAPI_PlaidML_Pipelines (0 ms total)

doesn't it work anymore ?

force_builders=Custom
buildworker:Custom=linux-1
build_image:Custom=plaidml2
test_modules:Custom=gapi
test_filter:Custom=*ML*

alalek · 2021-03-25T21:06:55Z

build_image:Custom=plaidml2

This would work if we remove build_image:Custom=ubuntu-openvino-2021.1.0:20.04 above (or comment out).

TolyaTalamanov · 2021-03-26T07:37:14Z

Now, it's OK, thanks!

[==========] Running 3 tests from 1 test case.
[----------] Global test environment set-up.
[----------] 3 tests from GAPI_PlaidML_Pipelines
[ RUN      ] GAPI_PlaidML_Pipelines.SimpleArithmetic
[       OK ] GAPI_PlaidML_Pipelines.SimpleArithmetic (137 ms)
[ RUN      ] GAPI_PlaidML_Pipelines.TwoInputOperations
[       OK ] GAPI_PlaidML_Pipelines.TwoInputOperations (82 ms)
[ RUN      ] GAPI_PlaidML_Pipelines.TwoOutputOperations
[       OK ] GAPI_PlaidML_Pipelines.TwoOutputOperations (87 ms)
[----------] 3 tests from GAPI_PlaidML_Pipelines (306 ms total)
[----------] Global test environment tear-down
[==========] 3 tests from 1 test case ran. (306 ms total)
[  PASSED  ] 3 tests.

dmatveev self-assigned this Mar 25, 2021

dmatveev added the category: g-api / gapi label Mar 25, 2021

dmatveev requested a review from rgarnov March 25, 2021 18:00

dmatveev added this to the 4.5.2 milestone Mar 25, 2021

dmatveev approved these changes Mar 25, 2021

View reviewed changes

Support RMat for PlaidML backend

6ba9906

TolyaTalamanov force-pushed the at/rmat-plaidml-backend branch from 544d22e to 6ba9906 Compare March 26, 2021 06:01

opencv-pushbot merged commit 77bfd94 into opencv:master Mar 26, 2021

rgarnov approved these changes Mar 26, 2021

View reviewed changes

alalek mentioned this pull request Apr 9, 2021

(5.x) Merge 4.x #19885

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

[G-API] Support RMat for PlaidML backend #19782

[G-API] Support RMat for PlaidML backend #19782

Uh oh!

TolyaTalamanov commented Mar 25, 2021 •

edited

Loading

Uh oh!

dmatveev left a comment

Uh oh!

dmatveev Mar 25, 2021

Uh oh!

rgarnov Mar 26, 2021

Uh oh!

TolyaTalamanov commented Mar 25, 2021

Uh oh!

alalek commented Mar 25, 2021

Uh oh!

TolyaTalamanov commented Mar 26, 2021

Uh oh!

Uh oh!

Uh oh!

[G-API] Support RMat for PlaidML backend #19782

[G-API] Support RMat for PlaidML backend #19782

Uh oh!

Conversation

TolyaTalamanov commented Mar 25, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request Readiness Checklist

Build configuration

Uh oh!

dmatveev left a comment

Choose a reason for hiding this comment

Uh oh!

dmatveev Mar 25, 2021

Choose a reason for hiding this comment

Uh oh!

rgarnov Mar 26, 2021

Choose a reason for hiding this comment

Uh oh!

TolyaTalamanov commented Mar 25, 2021

Uh oh!

alalek commented Mar 25, 2021

Uh oh!

TolyaTalamanov commented Mar 26, 2021

Uh oh!

Uh oh!

TolyaTalamanov commented Mar 25, 2021 •

edited

Loading