CARVIEW |
Navigation Menu
-
-
Notifications
You must be signed in to change notification settings - Fork 56.2k
[G-API] Implement async infer #19425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I believe it is a time to configure git hooks: https://github.com/opencv/opencv/wiki/How_to_contribute |
ee439d4
to
1b0200d
Compare
@@ -937,6 +953,339 @@ TEST_F(ROIListNV12, Infer2MediaInputNV12) | |||
validate(); | |||
} | |||
|
|||
TEST(Infer, TestStreamingInfer) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Again huge code duplication, should it be solved in separate task ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Filed a task.
2d38880
to
dd6c8e3
Compare
dd6c8e3
to
eb1287b
Compare
eb1287b
to
1342438
Compare
@AsyaPronina @smirnov-alexey Could you have a look ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
@AsyaPronina could you have a look ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No clear change overview given in the description :(
7148c07
to
29742d8
Compare
29742d8
to
c690ece
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, let's merge this!
Waiting for nireq
to come!
inline IE::Blob::Ptr extractBlob(IECallContext& ctx, std::size_t i, Views& views) { | ||
switch (ctx.in_shapes[i]) { | ||
inline IE::Blob::Ptr extractBlob(IECallContext& ctx, std::size_t i) { | ||
switch (ctx.inShape(i)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TolyaTalamanov
There are several warnings in Windows builds with IE.
Please take a look.
C:\build\precommit_custom_windows\opencv\modules\gapi\src\backends\ie\giebackend.cpp(467): warning C4267: 'argument': conversion from 'size_t' to 'int', possible loss of data [C:\build\precommit_custom_windows\build\modules\gapi\opencv_gapi.vcxproj]
C:\build\precommit_custom_windows\opencv\modules\gapi\src\backends\ie\giebackend.cpp(631): warning C4267: 'argument': conversion from 'size_t' to 'int', possible loss of data [C:\build\precommit_custom_windows\build\modules\gapi\opencv_gapi.vcxproj]
C:\build\precommit_custom_windows\opencv\modules\gapi\src\backends\ie\giebackend.cpp(660): warning C4267: 'argument': conversion from 'size_t' to 'int', possible loss of data [C:\build\precommit_custom_windows\build\modules\gapi\opencv_gapi.vcxproj]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it! Will be fixed in there: #19533
[G-API] Implement async infer * Implement async infer * Fix typo
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.