CARVIEW |
Navigation Menu
-
-
Notifications
You must be signed in to change notification settings - Fork 56.2k
[G-API] Python backend #19351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[G-API] Python backend #19351
Conversation
e81e312
to
665beb3
Compare
79f351b
to
1610363
Compare
988bb68
to
3ac4340
Compare
d209fc3
to
9c02d39
Compare
@dmatveev Have a look, please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 approved
using Impl = std::function<cv::GRunArgs(const cv::GArgs&, | ||
const cv::GTypesInfo&, | ||
const cv::GTypesInfo&)>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it required here or can it be part of GPythonKernel
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought about it, but it's used in GPythonFunctor
as well, so let it be, if it isn't a big deal
std::string tag; | ||
if (!pyopencv_to(PyTuple_GetItem(pair, 1), tag, ArgInfo("tag", false))) | ||
{ | ||
PyErr_SetString(PyExc_TypeError, "Failed to obtain kernel tag. Must be string"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What must be string?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tag must be string
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
|
||
comp = cv.GComputation(g_in, g_out) | ||
|
||
pkg = cv.gapi_wip_kernels((custom_mean, 'org.opencv.core.math.mean')) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can it be cv.gapi.wip_kernels
instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
...don't spend much time here if it is not
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, it can't, all custom function placed in cv2
package, I believe we work it out in future
b9ee785
to
abca930
Compare
abca930
to
79d4a38
Compare
@alalek Can it be merged ? |
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.
Build configuration