CARVIEW |
Navigation Menu
-
-
Notifications
You must be signed in to change notification settings - Fork 56.2k
[G-API] Support GFrame for infer #19002
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 approved, thanks!
std::back_inserter(context.in_shapes), | ||
[](const cv::GArg& arg) { | ||
return arg.get<cv::gimpl::RcDesc>().shape; | ||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So do you use it really?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use it to distinguish cv::GMat
& cv::GFrame
@alalek CI is read: Can it be the problem with OpenVINO version ? |
Mentioned sample is available since OV 2019 R2. You are testing using OV LTS release:
Need to add proper version check through BTW, You can use different OV versions on Linux/Windows/Mac configurations to perform robust checking (recommended). |
1e2515e
to
3940579
Compare
@alalek Custom jobs failed due known problems (cpu options isn't supported in this OV version) I think it can be merged |
Really? I see this:
and missing build images (OV LTS 2020.3.1 is not supported for now). Consider using 2021.1 instead. Compilation must be fixed before merge. |
2021.1 isn't supported on CI, is it ? |
Supported (on Linux in Ubuntu 20.04 container): https://github.com/opencv/opencv/wiki/CI-configuration |
util::throw_error(std::runtime_error("Unsupported input meta for IE backend")); | ||
} | ||
|
||
if (util::holds_alternative<cv::GMatDesc>(mm_0)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't this checked in switch
? For what case is it, if not.
Was able to successfully built with both 2020.03 and 2021.01 on my Ubuntu 18.04 |
@alalek can you have a look at this https://pullrequest.opencv.org/buildbot/builders/precommit_custom_linux/builds/5124? |
Use this Wiki page for proper names of available build images: https://github.com/opencv/opencv/wiki/CI-configuration Should be |
f1579d6
to
f83b37a
Compare
Missed that, thanks! |
@alalek can we merge this if the build will be green? There was a warning on Mac which hopefully will be fixed and other warnings are:
and
|
Yes, even with warnings on "optional" configuration (in scope of OpenCV, not G-API) if these warnings are not related to this PR (the same issues are with other G-API PRs on the same configurations). |
Let's merge this - we need this feature for the next internal update |
@alalek the build is green except for 2 warnings I've mentioned above (which have nothing to do with this PR). Can we merge this? |
@alalek Thanks! |
Fantastic! |
[G-API] Support GFrame for infer * GInfer(GFrame), currently broken * Fixed (API only) * Support GFrame in GIEBackend * Fix comments to review * Fix comments to review * Fix doxygen * Fix building with different IE versions * Fix warning on MacOS Co-authored-by: Dmitry Matveev <dmitry.matveev@intel.com> Co-authored-by: Smirnov Alexey <alexey.smirnov@intel.com>
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.