G-API: Introduce streaming::desync and infer(ROI) #18673

dmatveev · 2020-10-27T21:05:48Z

This patch is mainly upstreaming of a long-live internal branch.
The functionality has been tested already in the "real world" scenarios.

desync() is a new (and for now, the only one) intrinsic
which splits the graph execution into asynchronous parts
when running in Streaming mode;
desync() makes no effect when compiling in Traditional mode;
Added tests on desync() working in various scenarios;
Extended GStreamingExecutor to support desync(); also extended
GStreamingCompiled() with a new version of pull() returning a
vector of optional values;
Fixed various issues with storing the type information & proper
construction callbacks for GArray<> and GOpaque;
Introduced a new infer(Roi,GMat) overload with a sample;
Introduced an internal API for Islands to control fusion
procedure (to fuse or not to fuse);
Introduced handleStopStream() callback for island executables;
Added GCompileArgs to metadata of the graph (required for other
features).

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

I agree to contribute to the project under Apache 2 License.
To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
The PR is proposed to proper branch
There is reference to original bug report and related work
There is accuracy test, performance test and test data in opencv_extra repository, if applicable
Patch to opencv_extra has the same branch name.
The feature is well documented and sample code can be built with the project CMake

force_builders=Custom,Custom Win,Custom Mac
build_gapi_standalone:Linux x64=ade-0.1.1f
build_gapi_standalone:Win64=ade-0.1.1f
build_gapi_standalone:Mac=ade-0.1.1f
build_gapi_standalone:Linux x64 Debug=ade-0.1.1f
Xbuild_image:Custom=centos:7
Xbuildworker:Custom=linux-1
build_gapi_standalone:Custom=ade-0.1.1f
build_image:Custom=ubuntu-openvino-2020.3.0:16.04
build_image:Custom Win=openvino-2020.3.0
build_image:Custom Mac=openvino-2020.3.0
test_modules:Custom=gapi
test_modules:Custom Win=gapi
test_modules:Custom Mac=gapi
buildworker:Custom=linux-1
# disabled due high memory usage: test_opencl:Custom=ON
test_opencl:Custom=OFF
test_bigdata:Custom=1
test_filter:Custom=*

dmatveev · 2020-10-28T13:39:41Z

@TolyaTalamanov @rgarnov builds are green.

Let's have a look on this one more time and get it merged then

modules/gapi/test/streaming/gapi_streaming_tests.cpp

- desync() is a new (and for now, the only one) intrinsic which splits the graph execution into asynchronous parts when running in Streaming mode; - desync() makes no effect when compiling in Traditional mode; - Added tests on desync() working in various scenarios; - Extended GStreamingExecutor to support desync(); also extended GStreamingCompiled() with a new version of pull() returning a vector of optional values; - Fixed various issues with storing the type information & proper construction callbacks for GArray<> and GOpaque; - Introduced a new infer(Roi,GMat) overload with a sample; - Introduced an internal API for Islands to control fusion procedure (to fuse or not to fuse); - Introduced handleStopStream() callback for island executables; - Added GCompileArgs to metadata of the graph (required for other features).

dmatveev · 2020-10-29T18:46:08Z

@alalek @mshabunin review complete, required builds passed. Can you please merge it? We need to have this in our baseline before next Wed. Thanks!

dmatveev · 2020-10-29T18:47:08Z

modules/gapi/samples/infer_single_roi.cpp

+    auto ext = model_path.substr(sz - EXT_LEN);
+    std::transform(ext.begin(), ext.end(), ext.begin(), [](unsigned char c){
+            return static_cast<unsigned char>(std::tolower(c));
+        });


so I know about cv::toLowerCase but let's address this in another MR (with a test on InferROI)

dmatveev · 2020-10-29T21:02:03Z

Fantastic! Thanks!

dmatveev added the category: g-api / gapi label Oct 27, 2020

dmatveev added this to the 4.5.1 milestone Oct 27, 2020

dmatveev requested review from TolyaTalamanov and rgarnov October 27, 2020 21:05

dmatveev self-assigned this Oct 27, 2020

dmatveev force-pushed the dm/upstream_desync branch 2 times, most recently from e8a57aa to 47d3275 Compare October 28, 2020 10:37

rgarnov approved these changes Oct 28, 2020

View reviewed changes

modules/gapi/test/streaming/gapi_streaming_tests.cpp Show resolved Hide resolved

modules/gapi/test/streaming/gapi_streaming_tests.cpp Outdated Show resolved Hide resolved

TolyaTalamanov approved these changes Oct 29, 2020

View reviewed changes

dmatveev force-pushed the dm/upstream_desync branch from 47d3275 to ca8bb8d Compare October 29, 2020 17:20

dmatveev commented Oct 29, 2020

View reviewed changes

alalek assigned rgarnov and unassigned dmatveev Oct 29, 2020

opencv-pushbot merged commit 691c3d1 into opencv:master Oct 29, 2020

alalek mentioned this pull request Nov 27, 2020

Merge 4.x #18951

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

G-API: Introduce streaming::desync and infer(ROI) #18673

G-API: Introduce streaming::desync and infer(ROI) #18673

Uh oh!

dmatveev commented Oct 27, 2020 •

edited

Loading

Uh oh!

dmatveev commented Oct 28, 2020

Uh oh!

Uh oh!

Uh oh!

dmatveev commented Oct 29, 2020

Uh oh!

dmatveev Oct 29, 2020

Uh oh!

dmatveev commented Oct 29, 2020

Uh oh!

Uh oh!

Uh oh!

G-API: Introduce streaming::desync and infer(ROI) #18673

G-API: Introduce streaming::desync and infer(ROI) #18673

Uh oh!

Conversation

dmatveev commented Oct 27, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request Readiness Checklist

Uh oh!

dmatveev commented Oct 28, 2020

Uh oh!

Uh oh!

Uh oh!

dmatveev commented Oct 29, 2020

Uh oh!

dmatveev Oct 29, 2020

Choose a reason for hiding this comment

Uh oh!

dmatveev commented Oct 29, 2020

Uh oh!

Uh oh!

dmatveev commented Oct 27, 2020 •

edited

Loading