You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR closes#16292 calib3d(docs): misleading/ wrong documentation for RT
This PR introduces fixes to the documentation of the calib3d module. In addition to improving the documentation, I did minor spelling, grammar, and style guide (line length mostly) work BUT restricted these to those function's documentation that I needed to touch for this PR.
Probably this should be back-ported to the 3.4 branch.
I would also advice to use K for the camera intrinsic matrix. A is used in the Zhang paper and most of the original terminology in the OpenCV doc is taken I believe from there.
But generally, I think K is used:
Just some thoughts.
I feel like the notion of homogeneous coordinates, homogeneous transform is missing from the doc while it is an important notion in robotics and in computer vision.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR closes #16292 calib3d(docs): misleading/ wrong documentation for RT
This PR introduces fixes to the documentation of the calib3d module. In addition to improving the documentation, I did minor spelling, grammar, and style guide (line length mostly) work BUT restricted these to those function's documentation that I needed to touch for this PR.
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.