Framework for dynamic videoio backends, FFmpeg and GStreamer plugins #13677

mshabunin · 2019-01-23T12:49:22Z

This pullrequest changes

Added ability to build plugins for videoio module. Implemented for two most popular backends: FFmpeg and GStreamer.

Defined C-interface for plugins
Added wrapper classes for dynamically loaded backends
Created cmake function for plugin creation
Created GStreamer plugin
- minor cleanup, use logging
Created FFmpeg plugin
- moved library initialization from static scope to first function call
Created script to build several configurations of plugins in Docker containers: ./opencv/modules/videoio/misc/build_plugins.sh <path-to-dst-dir> <cmake-build-config>
environment variables to control plugin search:
- OPENCV_VIDEOIO_PLUGIN_PATH - list of directories to search for plugins (default is location of libopencv_videoio.so)
- OPENCV_VIDEOIO_PLUGIN_NAME - glob expression to match plugin binaries (default is libopencv_videoio_*.so)

Public interfaces

core: added two utility functions (getBinLocation, getParent)
videoio: added one registry function (hasBackend + enum)

Tests

FFmpeg and GStreamer tests are always enabled, will be skipped if backend is not available
Refactored FFmpeg parallel test
Removed fourcc test
renamed all test cases: videoio_xxx.yyy

Other changes

Refactored videoio registry

alalek

Great work!

modules/core/src/utils/filesystem.cpp

modules/videoio/cmake/plugin.cmake

modules/core/src/utils/datafile.cpp

modules/videoio/cmake/plugin.cmake

modules/videoio/misc/build_plugins.sh

modules/videoio/misc/plugin_ffmpeg/Dockerfile-ffmpeg

modules/videoio/cmake/plugin.cmake

alalek · 2019-02-04T12:27:52Z

modules/videoio/include/opencv2/videoio/registry.hpp

+{
+    Read,
+    Write,
+    ReadWrite


alalek · 2019-02-04T12:31:48Z

modules/videoio/src/cap_gstreamer.cpp

+    }
+    catch (...)
+    {
+    }


Some logging message would be useful here.

and below for "catch (...)"

alalek · 2019-02-04T12:48:43Z

modules/videoio/src/videoio_registry.cpp

            {
-                CV_LOG_INFO(NULL, "VIDEOIO: Disable backend: " << info.name);
+                const int env_priority2 = static_cast<int>(backendOrder.end() - backendPos - 1);
+                be.priority = 10000 + 1000 * env_priority2;


Was:

info.priority = (int)(100000 + (names.size() - i) * 1000);

Most part of changes here doesn't look necessary to add plugin support.

alalek · 2019-02-04T14:19:17Z

modules/videoio/src/videoio_registry.cpp

            {
-                info.priority = (int)param_priority;
-                enabled++;
+                Ptr<DynamicBackend> plugin = DynamicBackend::load(be.id, (int)be.mode);


We should not load plugins here.
Lets just assign priorities (keep old code).

At least, there is no way to bypass plugin loading via OPENCV_VIDEOIO_PRIORITY_XXX=0.

modules/videoio/misc/build_plugins.sh

alalek

Thank you 👍

mshabunin force-pushed the video_plugins branch from bc2bb34 to 2962a57 Compare January 24, 2019 13:49

alalek reviewed Jan 31, 2019

View reviewed changes

mshabunin force-pushed the video_plugins branch 2 times, most recently from 219e83d to 4447253 Compare February 1, 2019 10:04

alalek reviewed Feb 4, 2019

View reviewed changes

mshabunin force-pushed the video_plugins branch from 4447253 to 9c4fb65 Compare February 22, 2019 09:27

Framework for dynamic videoio backends, FFmpeg and GStreamer plugins

9702987

mshabunin force-pushed the video_plugins branch from e935346 to 9702987 Compare February 26, 2019 10:50

alalek approved these changes Feb 26, 2019

View reviewed changes

opencv-pushbot merged commit 9702987 into opencv:master Feb 26, 2019

opencv-pushbot pushed a commit that referenced this pull request Feb 26, 2019

Merge pull request #13677 from mshabunin:video_plugins

4188e8a

mshabunin deleted the video_plugins branch February 26, 2019 12:08

alalek mentioned this pull request Mar 4, 2019

videoio: plugins update #13970

Merged

alalek mentioned this pull request Mar 20, 2019

C++ cv::VideoCapture.open(0) always return false on Android #11952

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Framework for dynamic videoio backends, FFmpeg and GStreamer plugins #13677

Framework for dynamic videoio backends, FFmpeg and GStreamer plugins #13677

Uh oh!

mshabunin commented Jan 23, 2019 •

edited

Loading

Uh oh!

alalek left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

alalek Feb 4, 2019

Uh oh!

alalek Feb 4, 2019

Uh oh!

alalek Feb 4, 2019

Uh oh!

alalek Feb 4, 2019

Uh oh!

Uh oh!

alalek left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Framework for dynamic videoio backends, FFmpeg and GStreamer plugins #13677

Framework for dynamic videoio backends, FFmpeg and GStreamer plugins #13677

Uh oh!

Conversation

mshabunin commented Jan 23, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

This pullrequest changes

Public interfaces

Tests

Other changes

Uh oh!

alalek left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

alalek Feb 4, 2019

Choose a reason for hiding this comment

Uh oh!

alalek Feb 4, 2019

Choose a reason for hiding this comment

Uh oh!

alalek Feb 4, 2019

Choose a reason for hiding this comment

Uh oh!

alalek Feb 4, 2019

Choose a reason for hiding this comment

Uh oh!

Uh oh!

alalek left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

mshabunin commented Jan 23, 2019 •

edited

Loading