You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To silent compiler warnings, buf and timestamp could still be initialized to 0.
(ChatGPT)
âś… Conclusion
No problem with uninitialized variables here.
The variables are correctly assigned before use.
You could optionally zero-initialize them for clarity or to appease static analysis tools, but it's not functionally necessary.
Thx for fixing this. libwebp should be compiled with -DWEBP_ENABLE_NODISCARD.
Can you please also fix the following lines (the line numbers might be slightly off):
modules/imgcodecs/src/grfmt_webp.cpp:158:9: error: ignoring return value of function declared with 'nodiscard' attribute [-Werror,-Wunused-result]
158 | WebPAnimDecoderOptionsInit(&dec_options);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~ ~~~~~~~~~~~~
modules/imgcodecs/src/grfmt_webp.cpp:165:9: error: ignoring return value of function declared with 'nodiscard' attribute [-Werror,-Wunused-result]
165 | WebPAnimDecoderGetInfo(anim_decoder.get(), &anim_info);
| ^~~~~~~~~~~~~~~~~~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
modules/imgcodecs/src/grfmt_webp.cpp:219:9: error: ignoring return value of function declared with 'nodiscard' attribute [-Werror,-Wunused-result]
219 | WebPAnimDecoderGetNext(anim_decoder.get(), &buf, ×tamp);
| ^~~~~~~~~~~~~~~~~~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
modules/imgcodecs/src/grfmt_webp.cpp:449:5: error: ignoring return value of function declared with 'nodiscard' attribute [-Werror,-Wunused-result]
449 | WebPEncode(&config, &pic);
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #27456
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.