| CARVIEW |
Select Language
HTTP/2 302
date: Sat, 26 Jul 2025 08:58:59 GMT
content-length: 0
location: https://github.com/opencv/opencv/pull/27297
server-timing: nginx;desc="NGINX";dur=1.316317,glb;desc="GLB";dur=101.143378
x-voltron-version: a2eb102
vary: Accept-Encoding, Accept, X-Requested-With
server: github.com
x-frame-options: DENY
strict-transport-security: max-age=31536000; includeSubDomains; preload
set-cookie: _gh_sess=yu5vxKTRMbZIa3I6xxBSOO2qViK7JnuMZ82oeFuASE1xHalWgL5z9l6rZ0wKU310pCbGjX8T5VVyiN2xSuaZGec%2BrTtPLIOsBota%2FtiQspwlkgpnebdxPsPCb%2F%2FWl7Vxaa2VwL4zQf%2Bv7xSQhWeKaKqaPpFRyHBiU1sCMGLnI%2B6fGtMlDA0%2BkfGg1NidEn%2FfUq1mQmTrtonLCOz0zHsFgJOTfCRyZHCJ4GRtBVl882ZMr7ja1pJL7G05%2BTl7GadZ9Gw2OnRtz%2FParm3vQmKMhA%3D%3D--5%2BBTxZEytC0EZOA4--D2qGffYDP0eddvDRK4L3mA%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.2093115859.1753520338; Path=/; Domain=github.com; Expires=Sun, 26 Jul 2026 08:58:58 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sun, 26 Jul 2026 08:58:58 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: D334:2F5ED7:392B21:4CA777:688498D2
HTTP/2 200
date: Sat, 26 Jul 2025 08:59:00 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=283.193896,conversation_content-fragment;desc="conversation_content fragment";dur=626.987532,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=241.064118,nginx;desc="NGINX";dur=0.527622,glb;desc="GLB";dur=101.042509
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: a2eb102
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
x-github-request-id: D334:2F5ED7:392B59:4CA7A9:688498D2
imgcodecs: png: add log if first chunk is not IHDR by Kumataro · Pull Request #27297 · opencv/opencv · GitHub
Skip to content
Navigation Menu
{{ message }}
-
-
Notifications
You must be signed in to change notification settings - Fork 56.2k
imgcodecs: png: add log if first chunk is not IHDR #27297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @sturkmen72 |
sturkmen72
reviewed
May 10, 2025
modules/imgcodecs/test/test_png.cpp
Outdated
| Mat img; | ||
|
|
||
| // If first is IHDR chunk, output shall not be empty. | ||
| // 8 means PNG sigunature length. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
signature
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your review, I fixed this and next line.
(IHDR does not expect the length of chunk data is 4.)
- // If first is IHDR chunk, output shall not be empty.
- // 8 means PNG sigunature length.
- // 4 means lenght of chunk.
+ // If IHDR chunk found as the first chunk, output shall not be empty.
+ // 8 means PNG signature length.
+ // 4 means length field(uint32_t).| id = read_chunk(m_chunkIHDR); | ||
| if (id != id_IHDR) | ||
| { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
chatGPT suggests
if (id == id_CgBI)
{
CV_LOG_ERROR(NULL, "CgBI chunk (Apple private) found as the first chunk. IHDR is expected.");
}
else
{
CV_LOG_ERROR(NULL, "IHDR chunk shall be first. This data may be broken or malformed.");
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agreed to the message change.
This fix resulted in a complicated if statement, so I flattened it.
Before
if (id != id_IHDR)
{
if (id == id_CgBI)
{
CV_LOG_ERROR(NULL, "CgBI chunk (Apple private) found as the first chunk. IHDR is expected.");
}
else
{
CV_LOG_ERROR(NULL, "IHDR chunk shall be first. This data may be broken or malformed.");
}
return false;
}After
if (id == id_CgBI)
{
CV_LOG_ERROR(NULL, "CgBI chunk (Apple private) found as the first chunk. IHDR is expected.");
return false;
}
if (id != id_IHDR)
{
CV_LOG_ERROR(NULL, "IHDR chunk shall be first. This data may be broken or malformed.");
return false;
}I have also reflected this correction in the comments of the test code. Thank you very much !
asmorkalov
approved these changes
May 12, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Close #27295
To optimize for the native pixel format of the iPhone's early PowerVR GPUs, Apple implemented a non-standard PNG format.
Details: https://theapplewiki.com/wiki/PNG_CgBI_Format
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.