You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Isn't there a preparatory step to foresee so that (int)src.total() can be src.total() instead, in case of an hal implementation ? (I think there is none for now)
Isn't there a preparatory step to foresee so that (int)src.total() can be src.total() instead, in case of an hal implementation ? (I think there is none for now)
The prototype of cv_hal_meanStdDev is currently cv_hal_meanStdDev(..., int width, int height, ...), so just using a size_t tpix for width and 1 for height won't solve anything.
Either the prototype of cv_hal_meanStdDev() must change to accept size_t arguments, or it can only be used if width*height does not overflow.
@shyama7004, the added test requires 16Gb of RAM. That's a huge number, quite inconvenient for our CI. I suggest to, first of all, consider 8U type for array, not 32F and then reduce size of the array to a smaller number of elements, ~2 billions or so (e.g. (1<<16) x ((1<<15) + 10)). It will still cause 32-bit integer overflow, but it will take 8x less space than the current version
@shyama7004, the added test requires 16Gb of RAM. That's a huge number, quite inconvenient for our CI. I suggest to, first of all, consider 8U type for array, not 32F and then reduce size of the array to a smaller number of elements, ~2 billions or so (e.g. (1<<16) x ((1<<15) + 10)). It will still cause 32-bit integer overflow, but it will take 8x less space than the current version
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes : #26861
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.