You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@MaximSmolskiy I have tested it under Windows using MSVC and there should be no memory leak anymore.
But I just did a very basic test, I executed the imread function 100 times to read the jxl file, and the memory usage gradually went up to 659M before this PR, and after this PR, the memory usage was only 5M.
frankly i did not understand what is the difference calling release() or reset()
As I understand it, reset() releases the original resource managed by unique_ptr and initializes unique_ptr with a new pointer (nullptr by default). release() only releases ownership of the resource, returns the raw pointer to the caller, and then sets unique_ptr to nullptr.
When release() is called without saving its return value, the sole reference to the internal resource (the raw pointer) is lost, making the memory inaccessible and resulting in a memory leak.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Readiness Checklist
Fix #26766
It should additionally fix issue itself (problem with
remove
onWindows
), but I can't be completely sure - I can't test this onWindows
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.