| CARVIEW |
Select Language
HTTP/2 302
date: Sat, 26 Jul 2025 08:07:27 GMT
content-length: 0
location: https://github.com/opencv/opencv/pull/26690
server-timing: nginx;desc="NGINX";dur=0.91435,glb;desc="GLB";dur=101.015285
x-voltron-version: a2eb102
vary: Accept-Encoding, Accept, X-Requested-With
server: github.com
x-frame-options: DENY
strict-transport-security: max-age=31536000; includeSubDomains; preload
set-cookie: _gh_sess=0bBpOJjLoMIQuagWUj5aGLPDrm6%2B6coNFWiP2KFg1os2qORht6uaiZOLTcGHbPppnmkv3n8R%2FS%2B19N%2FhA06onDSUvSSOVlmOIXs%2BrYYXy8LP9LI%2FiXDctsgFlpgfLOWt01Dl0w0FX4C8TAmIG1g%2FmALGv6fWwAX82Ew60fGxOVbnamzP%2F6QUkVBXvzuJKInjjNSyUk41KBPQHVu%2BL2wyho%2BZ%2B4IAMN0GDuQUjq5xLn4YA9CcYrp2yQsYk38wuBQ%2FcZtMPrV3W5mzTvWhEs9BtQ%3D%3D--7ZsM6yFudeKOlahM--EyjFI9uUn3i%2B0t00BSRpiA%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1783444253.1753517246; Path=/; Domain=github.com; Expires=Sun, 26 Jul 2026 08:07:26 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sun, 26 Jul 2026 08:07:26 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: DAB0:1A1F38:336974:45445D:68848CBE
HTTP/2 200
date: Sat, 26 Jul 2025 08:07:27 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=270.419667,conversation_content-fragment;desc="conversation_content fragment";dur=464.037037,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=222.927992,nginx;desc="NGINX";dur=1.303263,glb;desc="GLB";dur=100.889345
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: a2eb102
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
x-github-request-id: DAB0:1A1F38:3369AD:4544AC:68848CBE
Speed up and reduce memory consumption for findContours by MaximSmolskiy · Pull Request #26690 · opencv/opencv · GitHub
MaximSmolskiy
deleted the
speed-up-and-reduce-memory-consumption-for-findContours
branch
December 31, 2024 10:00
Skip to content
Navigation Menu
{{ message }}
-
-
Notifications
You must be signed in to change notification settings - Fork 56.2k
Speed up and reduce memory consumption for findContours #26690
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
asmorkalov
merged 1 commit into
opencv:4.x
from
MaximSmolskiy:speed-up-and-reduce-memory-consumption-for-findContours
Dec 31, 2024
Merged
Speed up and reduce memory consumption for findContours #26690
asmorkalov
merged 1 commit into
opencv:4.x
from
MaximSmolskiy:speed-up-and-reduce-memory-consumption-for-findContours
Dec 31, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asmorkalov
approved these changes
Dec 31, 2024
MaximSmolskiy
deleted the
speed-up-and-reduce-memory-consumption-for-findContours
branch
|
Thank you for your work, but I tested and found that the speed of this function in version 4.11 is slower than in version 4.7. #include <opencv2/opencv.hpp>
using namespace std;
using namespace cv;
int main()
{
Mat img = imread("111.bmp", cv::IMREAD_GRAYSCALE);
cv::Mat mask;
inRange(img, 110, 120, mask);
std::vector<std::vector<cv::Point>> v_cont;
for (int i = 0; i < 10; i++)
{
v_cont.clear();
auto start = chrono::system_clock::now();
cv::findContours(mask, v_cont, cv::RETR_EXTERNAL, cv::CHAIN_APPROX_SIMPLE);
auto end = chrono::system_clock::now();
auto duration = chrono::duration_cast<chrono::microseconds>(end - start) / 1000.;
cout << "4.11 findContours cost" << double(duration.count()) << "ms" << endl;
}
}
|
Merged
This is because this function has been rewritten from C to C++ between these releases, it needs additional refactoring of internal structures in order to return to previous speed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Pull Request Readiness Checklist
Related to #26683
I ran reproducer from issue with one iteration.
Before
After
Speedup more than
2times and memory consumption reduction more than10timesSee details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.