CARVIEW |
Select Language
HTTP/2 302
date: Fri, 25 Jul 2025 14:27:16 GMT
content-length: 0
location: https://github.com/opencv/opencv/pull/26625
server-timing: nginx;desc="NGINX";dur=0.448929,glb;desc="GLB";dur=102.706826
x-voltron-version: a2eb102
vary: Accept-Encoding, Accept, X-Requested-With
server: github.com
x-frame-options: DENY
strict-transport-security: max-age=31536000; includeSubDomains; preload
set-cookie: _gh_sess=j5%2B6iilZK%2BCjaRhjEWDzPpkN4riRLzXaH8%2FP%2Bj9QDEf2e07DwI2lQZMagjWhkh0%2Fl8nZuhrSRqlK8jTrpC0YM6LY4rV07TuV3pGcC0G7oxMNaRf1mTzo%2F1e7kteQ7qW90viZqvVtNU1Z1CXkZQKtyeOTbBJ07Ek2GCRivG8%2F6AH1ZdMI2a9vT6XhhSY7%2FrGSO5NtfT04db4odZUE%2FxRxb7P5txcLu9DE%2B435okAj6EZUvEpAsW%2BCCBfT6b5faIfSYeMBDbm5YybkoAmHqC6aHw%3D%3D--UCWKrsDD7hlAQjQe--7fpqZp%2F41eOMf9tpJ%2B%2BcIg%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1740810790.1753453636; Path=/; Domain=github.com; Expires=Sat, 25 Jul 2026 14:27:16 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sat, 25 Jul 2026 14:27:16 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: 8EAC:FE58E:1E612:23DB6:68839444
HTTP/2 200
date: Fri, 25 Jul 2025 14:27:17 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=595.639337,conversation_content-fragment;desc="conversation_content fragment";dur=1085.687641,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=282.250059,nginx;desc="NGINX";dur=0.916763,glb;desc="GLB";dur=102.28868
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: a2eb102
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
x-github-request-id: 8EAC:FE58E:1E675:23E1A:68839444
Cocoa/highgui: fix leak in cvGetWindowRect_COCOA by NekoAsakura Β· Pull Request #26625 Β· opencv/opencv Β· GitHub
Skip to content
Navigation Menu
{{ message }}
-
-
Notifications
You must be signed in to change notification settings - Fork 56.2k
Cocoa/highgui: fix leak in cvGetWindowRect_COCOA #26625
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VadimLevin
requested changes
Dec 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on the following setup:
cpu: x86_64
macOS 15.2
Xcode 16.2
Requirements:
pip install --require-virtualenv psutil matplotlib
Code for testing:
import os
import cv2
import matplotlib.pyplot as plt
import numpy as np
import psutil
NUM_ITERATIONS = 1000
def plot_memory_usage(memory_usage):
plt.figure(figsize=(10, 5))
x = np.arange(len(memory_usage))
plt.plot(x, memory_usage, label="Memory Usage (KB)", color="blue")
plt.title("Memory Usage Over Time")
plt.xlabel("Iterations")
plt.ylabel("Memory Usage (KB)")
plt.legend()
plt.grid()
plt.savefig("test_opencv_memory_leak.png")
def main():
process = psutil.Process(os.getpid())
shape = (800, 600, 3)
image = np.random.randint(0, 255 + 1, np.prod(shape), np.uint8).reshape(shape)
memory_usage = np.zeros(NUM_ITERATIONS, dtype=np.float32)
cv2.namedWindow("image", cv2.WINDOW_NORMAL)
for i in range(NUM_ITERATIONS):
rect = cv2.getWindowImageRect("image")
cv2.imshow("image", image)
memory_usage[i] = process.memory_info().rss / 1024
if cv2.waitKey(1) == ord("q"):
break
print("Current memory:", memory_usage[-1], "KB")
print("Peak memory usage:", np.max(memory_usage), "KB")
plot_memory_usage(memory_usage)
if __name__ == "__main__":
main()
Current memory: 2154040.0 KB
Peak memory usage: 3587704.0 KB
I think, the drop in memory usage corresponds to time when ARC kicks in.
Current memory: 92292.0 KB
Peak memory usage: 92292.0 KB
VadimLevin
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You canβt perform that action at this time.
#26574 reported a memory leak occurring when calling
getWindowImageRect
on macOS. After investigation, it was found that the leak was caused by thecvGetWindowRect_COCOA
, which created several NSObject instances without setting up a local autorelease pool.opencv/modules/highgui/src/window_cocoa.mm
Lines 665 to 671 in 1d41108
The patch has been compiled and tested on macOS 15.1.1, confirming that the bug is resolved.
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.