| CARVIEW |
Select Language
HTTP/2 302
date: Sat, 26 Jul 2025 08:06:38 GMT
content-length: 0
location: https://github.com/opencv/opencv/pull/26147
server-timing: nginx;desc="NGINX";dur=0.546734,glb;desc="GLB";dur=100.896796
x-voltron-version: a2eb102
vary: Accept-Encoding, Accept, X-Requested-With
server: github.com
x-frame-options: DENY
strict-transport-security: max-age=31536000; includeSubDomains; preload
set-cookie: _gh_sess=wUl0VpF0KvkQVJrTgCuQTe%2BT0T%2Bp%2FZUSmwsO2j5%2BOer%2BAKcYMky8ekonWj%2BeIvo8ljlqXRG1nqi7aedV8EYtGMxl4waCMGgplZXvU9YX18ttGiv53QR%2BU524tS7mfmJhy8EgZhxIXYb2E3LPK%2BAK7yMZR5h70p4yawpy32UpbIqRAPRhLfmqCBSgxt%2FgCQbxfcJsbtGQ6q9WRFhNuzJu%2BrweRMf3Fcopczf1hbzEcjo5749tfefGmZxcbeyd3scUK%2BTp%2BsbQIRcdI1bGVWvARQ%3D%3D--7WkXU%2B%2FkHthzrS2W--gjOJbBwUvBe3qHnJuw8g0A%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.598240712.1753517198; Path=/; Domain=github.com; Expires=Sun, 26 Jul 2026 08:06:38 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sun, 26 Jul 2026 08:06:38 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: AEF6:37D5F1:32557A:44289D:68848C8E
HTTP/2 200
date: Sat, 26 Jul 2025 08:06:39 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=326.917929,conversation_content-fragment;desc="conversation_content fragment";dur=973.746503,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=277.186031,nginx;desc="NGINX";dur=0.993189,glb;desc="GLB";dur=101.005131
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: a2eb102
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
x-github-request-id: AEF6:37D5F1:3255A9:4428D9:68848C8E
js: fix enum generation issues by vrabaud · Pull Request #26147 · opencv/opencv · GitHub
?
vrabaud
changed the title
Fix some js generation issues.
js: fix enum generation issues
Dec 18, 2024
Skip to content
Navigation Menu
{{ message }}
-
-
Notifications
You must be signed in to change notification settings - Fork 56.2k
js: fix enum generation issues #26147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
RFC: what should we do for namespaces for const/enums? As we have a collision here, I prepended the |
|
Thx @asmorkalov , fixed. Does that mean that |
|
In long term - yes. |
asmorkalov
reviewed
Sep 16, 2024
Comment on lines
+940
to
+942
| # TODO CALIB_FIX_FOCAL_LENGTH is defined both in cv:: and cv::fisheye | ||
| prefix = 'FISHEYE_' if 'fisheye' in ns_name else '' | ||
| for name, const in sorted(ns.consts.items()): | ||
| name = prefix + name |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What if use namespace_prefix_override solution like for the functions? Namespace is already appended to the function names, if it's not overridden by config. It's less hacky and more obvious.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess that would work but I don't know how to use it. Should all the enums be added to
opencv/modules/js/generator/embindgen.py
Line 989 in 450e741
| namespace_prefix_override = { |
|
@asmorkalov , do you want me to split this PR in 3 per the 3 points I mentioned ? 2 should be easy to merge, the Python script needs more review (though parts of it can easily be merged, like the |
|
Yes, let's split. |
vrabaud
changed the title
|
#26644 was also split out of this PR. The PR now only contains enum-related changes. |
asmorkalov
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
enums were not taken into account
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request