| CARVIEW |
Select Language
HTTP/2 302
date: Sun, 27 Jul 2025 03:02:34 GMT
content-length: 0
location: https://github.com/opencv/opencv/pull/25880
server-timing: nginx;desc="NGINX";dur=1.254618,glb;desc="GLB";dur=101.017501
x-voltron-version: a2eb102
vary: Accept-Encoding, Accept, X-Requested-With
server: github.com
x-frame-options: DENY
strict-transport-security: max-age=31536000; includeSubDomains; preload
set-cookie: _gh_sess=g2U6GX8OF6BUzbweTkW%2B1OtMCyZsZ9c%2B5qkZfSBuPEYZTYJgnMq%2B8N%2Bx3EoZ1JcGxNZJt5XQoaBhOlyHwiawBgIjQQBGd4f46dkiBv3De9XkCnInzWwrEf8kW9CSP9iM%2BR2kDs8BJv9DGY9hRPCcztJoiQ1pIXB4q2KdTDpPAXV9JcohRlMOJZxzaQwEr4xy20ycXfsP8hRosa2HdxVcrUq7pQw2tNPDnMB5XrxXv44vXWVdkq6erH%2FCoOwX2eKyhVjFwLyMv6mFzzHDWATGRQ%3D%3D--nFWInDcZskLzc3tM--l65bSGpYgulAoGj2aewHuA%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.45374704.1753585354; Path=/; Domain=github.com; Expires=Mon, 27 Jul 2026 03:02:34 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Mon, 27 Jul 2026 03:02:34 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: DA32:3ED739:A21917:D803A6:688596CA
HTTP/2 200
date: Sun, 27 Jul 2025 03:02:35 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=376.527828,conversation_content-fragment;desc="conversation_content fragment";dur=1144.800683,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=346.329698,nginx;desc="NGINX";dur=1.294502,glb;desc="GLB";dur=101.06649
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: a2eb102
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
x-github-request-id: DA32:3ED739:A21936:D803D0:688596CA
🐛 Fix CUDA for old GPUs without FP16 support by Jamim · Pull Request #25880 · opencv/opencv · GitHub
asmorkalov
added
category: gpu/cuda (contrib)
OpenCV 4.0+: moved to opencv_contrib
category: dnn
labels
Jul 8, 2024
Skip to content
Navigation Menu
{{ message }}
-
-
Notifications
You must be signed in to change notification settings - Fork 56.2k
🐛 Fix CUDA for old GPUs without FP16 support #25880
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 7, 2024
asmorkalov
added
category: gpu/cuda (contrib)
asmorkalov
requested changes
Jul 8, 2024
asmorkalov
reviewed
Jul 9, 2024
modules/dnn/src/registry.cpp
Outdated
Comment on lines
128
to
129
| if (cuda4dnn::doesDeviceSupportFP16()) | ||
| backends.push_back(std::make_pair(DNN_BACKEND_CUDA, DNN_TARGET_CUDA_FP16)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works well with single gpu configuration. The current GPU may be old and does not support FP16, but the second one does. It's popular case, if one GPU is used for rendering another one - for compute.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is fine to check the CURRENT CUDA device.
Lets left the caller responsibility to properly select used device via cudaSetDevice before these calls.
BTW, OpenCL backend has similar problems but looks like they are handled in another place.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I pushed fix for the issue and extended check to target management. @opencv-alalek could you take a look again?
asmorkalov
approved these changes
Jul 9, 2024
|
@Jamim Could you pull the branch from Github and test the last commit with your GPU. |
|
Could you pull the branch from Github and test the last commit with your GPU.
Sorry, I'm not at home now. I'll be able to do so in the evening.
|
Jamim
commented
Jul 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @asmorkalov,
I've tested your changes and they work well on my system.
Also, I have a couple of minor suggestions. Please take a look.
Co-authored-by: Aliaksei Urbanski <aliaksei.urbanski@gmail.com>
opencv-alalek
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Fixes #21461
This is a build-time solution that reflects https://github.com/opencv/opencv/blob/4.10.0/modules/dnn/src/cuda4dnn/init.hpp#L68-L82.We shouldn't add an invalid target while building withCUDA_ARCH_BIN< 53.(please see this discussion)
This is a run-time solution that basically reverts these lines.
I've debugged these changes, coupled with other fixes, on Gentoo Linux and related tests passed on my laptop with
GeForce GTX 960M.Alternative solution:
Best regards!
Pull Request Readiness Checklist
n/aThere is accuracy test, performance test and test data in opencv_extra repository, if applicablen/aThe feature is well documented and sample code can be built with the project CMake