CARVIEW |
Navigation Menu
-
-
Notifications
You must be signed in to change notification settings - Fork 56.2k
videoio
: fix cv::VideoWriter
with FFmpeg encapsulation timestamps
#25874
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
videoio
: fix cv::VideoWriter
with FFmpeg encapsulation timestamps
#25874
Conversation
ad6229c
to
63f47fd
Compare
63f47fd
to
98eaf49
Compare
Updated to address warnings
|
1ff05be
to
ecef325
Compare
Linux warning:
|
ecef325
to
eafbf4b
Compare
I've pushed an update which should address this. |
@opencv-alalek @mshabunin could you take a look too? |
Reporduced failed test with Ubuntu 16.04 locally. Will take a look, if we can handle this:
|
Looks similar to what we discussed in #24363. |
eafbf4b
to
3baf2ec
Compare
Its the same issue but unfortunately can't be fixed by using a .avi container because the pts infomation is not available. Changing to .ts works for me with FFMpeg 2.8.22 (Ubuntu 16.04) and 4.2.9 (Ubuntu 20.04) |
…capsulate_ts videoio: fix cv::VideoWriter with FFmpeg encapsulation timestamps opencv#25874 Fix opencv#25873 by modifying `cv::VideoWriter` to use provided presentation indices (pts). ### Pull Request Readiness Checklist See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request - [x] I agree to contribute to the project under Apache 2 License. - [x] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV - [x] The PR is proposed to the proper branch - [x] There is a reference to the original bug report and related work - [x] There is accuracy test, performance test and test data in opencv_extra repository, if applicable Patch to opencv_extra has the same branch name. - [x] The feature is well documented and sample code can be built with the project CMake
…capsulate_ts videoio: fix cv::VideoWriter with FFmpeg encapsulation timestamps opencv#25874 Fix opencv#25873 by modifying `cv::VideoWriter` to use provided presentation indices (pts). ### Pull Request Readiness Checklist See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request - [x] I agree to contribute to the project under Apache 2 License. - [x] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV - [x] The PR is proposed to the proper branch - [x] There is a reference to the original bug report and related work - [x] There is accuracy test, performance test and test data in opencv_extra repository, if applicable Patch to opencv_extra has the same branch name. - [x] The feature is well documented and sample code can be built with the project CMake
Fix #25873 by modifying
cv::VideoWriter
to use provided presentation indices (pts).Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.