CARVIEW |
Navigation Menu
-
-
Notifications
You must be signed in to change notification settings - Fork 56.2k
Add support for QNX #25832
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for QNX #25832
Conversation
if(${CMAKE_SYSTEM_NAME} MATCHES QNX) | ||
include_directories(AFTER "${dir}") | ||
else() | ||
include_directories(AFTER SYSTEM "${dir}") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the problem? message?
If there is no SYSTEM headers support then it should be disabled on CMake level.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cd /home/chachoi/chachoi-world/qnx-ports/opencv/nto-aarch64-le/build/modules/imgcodecs && /home/chachoi/qnx800/host/linux/x86_64/usr/bin/qcc -lang-c++ -DCVAPI_EXPORTS -DHAVE_IMGCODEC_HDR -DHAVE_IMGCODEC_PFM -DHAVE_IMGCODEC_PXM -DHAVE_IMGCODEC_SUNRASTER -DHAVE_WEBP -DOPJ_STATIC -D_USE_MATH_DEFINES -D__OPENCV_BUILD=1 -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/home/chachoi/chachoi-world/opencv/3rdparty/openjpeg/openjp2 -I/home/chachoi/chachoi-world/qnx-ports/opencv/nto-aarch64-le/build/3rdparty/openjpeg/openjp2 -I/home/chachoi/chachoi-world/opencv/3rdparty/libwebp/src -I/home/chachoi/chachoi-world/opencv/modules/imgcodecs/include -I/home/chachoi/chachoi-world/qnx-ports/opencv/nto-aarch64-le/build/modules/imgcodecs -I/home/chachoi/chachoi-world/opencv/modules/core/include -I/home/chachoi/chachoi-world/opencv/modules/imgproc/include -Wp,-isystem,/home/chachoi/chachoi-world/qnx-ports/opencv/nto-aarch64-le/build -Wp,-isystem,/home/chachoi/qnx800/target/qnx/usr/include -Vgcc_ntoaarch64le -I. -I/home/chachoi/chachoi-world/qnx-ports/opencv/nto-aarch64-le -I/home/chachoi/chachoi-world/qnx-ports/opencv -I/home/chachoi/qnx800/target/qnx/usr/include -I/home/chachoi/qnx800/target/qnx/aarch64le//usr/local/include -D_QNX_SOURCE -fsigned-char -O3 -DNDEBUG -O3 -DNDEBUG -fPIC -std=c++17 -o CMakeFiles/opencv_imgcodecs.dir/src/loadsave.cpp.o -c /home/chachoi/chachoi-world/opencv/modules/imgcodecs/src/loadsave.cpp
cc: warning - lang-c++ is deprecated
In file included from /home/chachoi/qnx800/target/qnx/usr/include/c++/v1/__type_traits/remove_reference.h:13,
from /home/chachoi/qnx800/target/qnx/usr/include/c++/v1/__type_traits/apply_cv.h:15,
from /home/chachoi/qnx800/target/qnx/usr/include/c++/v1/__functional/invoke.h:15,
from /home/chachoi/qnx800/target/qnx/usr/include/c++/v1/type_traits:421,
from /home/chachoi/qnx800/target/qnx/usr/include/c++/v1/limits:827,
from /home/chachoi/chachoi-world/opencv/modules/core/include/opencv2/core/cvdef.h:185,
from /home/chachoi/chachoi-world/opencv/modules/core/include/opencv2/core.hpp:52,
from /home/chachoi/chachoi-world/opencv/modules/imgcodecs/include/opencv2/imgcodecs.hpp:46,
from /home/chachoi/chachoi-world/opencv/modules/imgcodecs/src/precomp.hpp:45,
from /home/chachoi/chachoi-world/opencv/modules/imgcodecs/src/loadsave.cpp:46:
/home/chachoi/qnx800/target/qnx/usr/include/c++/v1/cstddef:46:5: error: #error <cstddef> tried including <stddef.h> but didn't find libc++'s <stddef.h> header. This usually means that your header search paths are not configured properly. The header search paths should contain the C++ Standard Library headers before any C Standard Library, and you are probably using compiler flags that make that not be the case.
46 | # error <cstddef> tried including <stddef.h> but didn't find libc++'s <stddef.h> header. \
QNX headers at -isystem,/home/chachoi/qnx800/target/qnx/usr/include
being treated as system headers causes the compile issue above. I tried setting CMAKE_NO_SYSTEM_FROM_IMPORTED
to ON
, but it did not work.
@opencv-alalek could you take a look? |
CMakeLists.txt
Outdated
@@ -129,6 +129,10 @@ if(OPENCV_WORKAROUND_CMAKE_20989) | |||
set(CMAKE_SYSTEM_PROCESSOR ${CMAKE_SYSTEM_PROCESSOR_BACKUP}) | |||
endif() | |||
|
|||
if(CMAKE_SYSTEM_NAME MATCHES QNX) | |||
set(OPENCV_PYTHON_INSTALL_PATH ${QNX_PYTHON_INSTALL_PATH}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't need to introduce QNX_PYTHON_INSTALL_PATH
(google doesn't know that anyway).
Just specify OPENCV_PYTHON_INSTALL_PATH
value to CMake thorugh command-line or via cmake/OpenCVInstallLayout.cmake
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I removed this and passed OPENCV_PYTHON_INSTALL_PATH
via toolchain.
@chachoi @opencv-alalek What are the next steps here? |
Friendly reminder. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 Thank you for contribution!
Thanks everyone 👍 |
Add support for QNX opencv#25832 Build and test instruction for QNX: https://github.com/chachoi-world/qnx-ports/blob/main/opencv/README.md ### Pull Request Readiness Checklist See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request - [x] I agree to contribute to the project under Apache 2 License. - [x] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV - [x] The PR is proposed to the proper branch - [ ] There is a reference to the original bug report and related work - [ ] There is accuracy test, performance test and test data in opencv_extra repository, if applicable Patch to opencv_extra has the same branch name. - [ ] The feature is well documented and sample code can be built with the project CMake
Add support for QNX opencv#25832 Build and test instruction for QNX: https://github.com/chachoi-world/qnx-ports/blob/main/opencv/README.md ### Pull Request Readiness Checklist See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request - [x] I agree to contribute to the project under Apache 2 License. - [x] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV - [x] The PR is proposed to the proper branch - [ ] There is a reference to the original bug report and related work - [ ] There is accuracy test, performance test and test data in opencv_extra repository, if applicable Patch to opencv_extra has the same branch name. - [ ] The feature is well documented and sample code can be built with the project CMake
Build and test instruction for QNX:
https://github.com/chachoi-world/qnx-ports/blob/main/opencv/README.md
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.