| CARVIEW |
Select Language
HTTP/2 302
date: Sun, 27 Jul 2025 03:06:16 GMT
content-length: 0
location: https://github.com/opencv/opencv/pull/25809
server-timing: nginx;desc="NGINX";dur=0.92524,glb;desc="GLB";dur=100.814354
x-voltron-version: a2eb102
vary: Accept-Encoding, Accept, X-Requested-With
server: github.com
x-frame-options: DENY
strict-transport-security: max-age=31536000; includeSubDomains; preload
set-cookie: _gh_sess=U9xNtdZ4QJMjZ6igR5ArA3o0ouAcIQmEZhw6VK80LYpYZsFbiok3vG%2FFraXOIWoqIZ2UeM88iQeDLbNASGIYQgPfIHZNnhITk06NhzNgRjZXSvG%2BTwnKczUS0SAk7kEUPsFVyVLCmvtHEIKZus9wbB05zqInHhcCudqoaVKpUdrwUx0HwHrQ2Kwno2faaQMvBCybvpaoZxAXh7IDwpJM41GmO7FRz7l%2BGkfJu%2BdVxDRySOLiCueEmn0Tnz6jfaxWIY%2F1sQbesE45JU75%2BoaXCQ%3D%3D--oyAq2lnpiPBuVS72--EUeNlyQJJ8JszJIto2%2B1tw%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.69008752.1753585576; Path=/; Domain=github.com; Expires=Mon, 27 Jul 2026 03:06:16 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Mon, 27 Jul 2026 03:06:16 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: E31C:3C6DB4:D0DAC:147D64:688597A8
HTTP/2 200
date: Sun, 27 Jul 2025 03:06:18 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=372.643848,conversation_content-fragment;desc="conversation_content fragment";dur=1221.885763,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=254.089256,nginx;desc="NGINX";dur=1.040894,glb;desc="GLB";dur=100.436897
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: a2eb102
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
x-github-request-id: E31C:3C6DB4:D0DCE:147D92:688597A8
imgcodecs: Add rgb flag for imread and imdecode by zihaomu · Pull Request #25809 · opencv/opencv · GitHub
asmorkalov
changed the title
imgcodecs: Add rgb flag
imgcodecs: Add rgb flag for imread and imdecode
Jul 1, 2024
Skip to content
Navigation Menu
{{ message }}
-
-
Notifications
You must be signed in to change notification settings - Fork 56.2k
imgcodecs: Add rgb flag for imread and imdecode #25809
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asmorkalov
reviewed
Jun 24, 2024
asmorkalov
reviewed
Jun 26, 2024
|
I propose to extend existing perf tests with RGB case. Just to be sure that the new mode does not introduce significant degradation. |
asmorkalov
reviewed
Jun 28, 2024
asmorkalov
reviewed
Jun 28, 2024
Comment on lines
+86
to
+93
| img = imread(root + "readwrite/color_palette_alpha.png", IMREAD_COLOR_RGB); | ||
| ASSERT_FALSE(img.empty()); | ||
| ASSERT_TRUE(img.channels() == 3); | ||
|
|
||
| // pixel is red in RGB | ||
| EXPECT_EQ(img.at<Vec3b>(0, 0), Vec3b(255, 0, 0)); | ||
| EXPECT_EQ(img.at<Vec3b>(0, 1), Vec3b(255, 0, 0)); | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I propose to add test with RGBA output.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @asmorkalov. For consistency, IMREAD_COLOR_RGB currently converts all RGBA to RGB instead of RGBA output.
asmorkalov
reviewed
Jun 28, 2024
|
Perf results for system wide (Ubuntu 16.04) and own (from 3rdparty) on Jetson-tk1 (ARMv7+NEON): |
asmorkalov
changed the title
asmorkalov
approved these changes
Jul 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
đź‘Ť
vpisarev
approved these changes
Jul 3, 2024
Merged
Eldies
added a commit
to cvat-ai/datumaro
that referenced
this pull request
Feb 7, 2025
6 tasks
zhiltsov-max
added a commit
to cvat-ai/datumaro
that referenced
this pull request
Feb 10, 2025
6 tasks
zhiltsov-max
added a commit
to cvat-ai/datumaro
that referenced
this pull request
Feb 10, 2025
Restrict opencv version to below 4.11 to keep api stable after opencv/opencv#25809
Eldies
added a commit
to cvat-ai/datumaro
that referenced
this pull request
Mar 5, 2025
* syncing util/mask_tools.py * syncing util/image.py * keeping exif unconditionally * syncing components/media.py * syncing components/importer.py * syncing util/meta_file_util.py * moving cli/contexts/project/diff.py to cli/util/compare.py * moving Registry and PluginRegistry to components/registry.py * syncing components/exporter.py * syncing components/hl_ops.py * syncing components/dataset.py * limiting opencv version (due to opencv/opencv#25809) * fixes * upper case extension fix * fixes * always keeping exif info * limiting opencv version * Update src/datumaro/components/media.py Co-authored-by: Maxim Zhiltsov <zhiltsov.max35@gmail.com> * test for reading exif orientation * changelog entry * fixed isort * fixed test * fixed changelog * Update src/datumaro/components/hl_ops/__init__.py Co-authored-by: Maxim Zhiltsov <zhiltsov.max35@gmail.com> * fixing filter examples * hl_ops tests * syncing plugins/data_formats/celeba * syncing plugins/data_formats/cifar.py * setting DETECT_CONFIDENCE for yolo formats * syncing plugins/data_formats/image_dir.py * better detection for yolo classification importer * syncing plugins/data_formats/imagenet.py and plugins/data_formats/imagenet_txt.py * syncing plugins/data_formats/camvid.py * syncing tests/integration/cli/test_detect_format.py * syncing cli/util/project.py * syncing tests/integration/cli/test_filter.py * syncing tests/integration/cli/test_transform.py * yolo streaming exporter * syncing plugins/data_formats/coco * Update src/datumaro/components/media.py Co-authored-by: Maxim Zhiltsov <zhiltsov.max35@gmail.com> * Update src/datumaro/components/media.py Co-authored-by: Maxim Zhiltsov <zhiltsov.max35@gmail.com> * Update src/datumaro/components/media.py Co-authored-by: Maxim Zhiltsov <zhiltsov.max35@gmail.com> * Update tests/unit/test_video.py Co-authored-by: Maxim Zhiltsov <zhiltsov.max35@gmail.com> * Update src/datumaro/components/registry.py Co-authored-by: Maxim Zhiltsov <zhiltsov.max35@gmail.com> * coco find_images_dir do not fail if images folder doe not exist - because cvat needs to be able to export and then import dataset without images * coco find_rootpath do not fail if path does not end with ANNOTATIONS_DIR - because cvat needs it * fixes * fix linters * tests for HLOps.compare * syncing tests/unit/test_image.py * accounting for the new flag in cv2 * syncing components/importer.py * fixes * fixes * fixes * fixes * tests in test_masks.py from upstream * a bit of info on ImageColorChannel.UNCHANGED * fixing wrong merge * removing bad changes * rolling back changes in test * do not recollect subset names in StreamDatasetStorage if transformations do not change subsets * fixes * Refactor with_subset_dirs * Support detect() calls with no return value * Update importer detection confidence * Lower the default confidence * Align default format detection confidence in detector and importer * Clean imports * syncing tests/conftest.py and tests/unit/data_formats/conftest.py * syncing imagenet tests * test new yolo classification detetection behaviour * syncing tests/unit/test_format_detection.py * Apply suggestions from code review Co-authored-by: Maxim Zhiltsov <zhiltsov.max35@gmail.com> * fixes * fixes * Apply suggestions from code review Co-authored-by: Maxim Zhiltsov <zhiltsov.max35@gmail.com> * small fixes * basic streaming tests for coco and yolo formats * returning previous tests and behaviour for coco * Improve function name * raising error on unknown image id * test coco streaming * test yolo streaming --------- Co-authored-by: Maxim Zhiltsov <zhiltsov.max35@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Try to
imreadimages by RGB to save R-B swapping costs.How to use it?
TODO
Performance test
Test with image_test.zip
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.