CARVIEW |
Select Language
HTTP/2 302
date: Sat, 26 Jul 2025 08:08:13 GMT
content-length: 0
location: https://github.com/opencv/opencv/pull/25779
server-timing: nginx;desc="NGINX";dur=1.122954,glb;desc="GLB";dur=101.219921
x-voltron-version: a2eb102
vary: Accept-Encoding, Accept, X-Requested-With
server: github.com
x-frame-options: DENY
strict-transport-security: max-age=31536000; includeSubDomains; preload
set-cookie: _gh_sess=s1CXYrVMzplQBysOkRH4u%2BHNKQUhaXHbDu%2ByqDeJby2r0Wa63ohePAb16DOhqbDJpRtK7CvyPr05DXi%2FYz8pgLhhfWxM3NOQwjRdEZsZXNGC2%2F4NGCAoAuh%2BolrxzIjAWnriG5wDjyfRBy09hWSxJfpxStHgqBuDxxqV7KVdr2FM8%2Fcjr5vtUrVQNMRQCY1MDhEkhCqHfGsNht%2FwMfTNfSlcyg0%2BslVSJhBtzDzyVzCSSehzurqdEAJ0FQOi2q7rMcnPkVQrcrAMUqa4QD9x%2Fw%3D%3D--3VsHaslNNKMPm3PC--IfzJ3hkVQ5haNQc9t%2BXN2g%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.317397634.1753517293; Path=/; Domain=github.com; Expires=Sun, 26 Jul 2026 08:08:13 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sun, 26 Jul 2026 08:08:13 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: EB1E:1369AB:331299:44F3C8:68848CED
HTTP/2 200
date: Sat, 26 Jul 2025 08:08:16 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=1133.15244,conversation_content-fragment;desc="conversation_content fragment";dur=2790.944459,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=268.301132,nginx;desc="NGINX";dur=0.823785,glb;desc="GLB";dur=101.151731
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: a2eb102
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
x-github-request-id: EB1E:1369AB:3312C9:44F415:68848CED
dnn: add DepthToSpace and SpaceToDepth by fengyuentau · Pull Request #25779 · opencv/opencv · GitHub
fengyuentau
added
category:dnn_timvx
TIM-VX related issues in DNN module
category:dnn_cann
CANN backend related issues in DNN module
labels
Jun 20, 2024
fengyuentau
changed the title
dnn: add dedicated DepthToSpace and SpaceToDepth layers
dnn: add a dedicated DepthSpaceLayer for DepthToSpace and SpaceToDepth
Jun 20, 2024
fengyuentau
changed the title
dnn: add a dedicated DepthSpaceLayer for DepthToSpace and SpaceToDepth
dnn: add DepthToSpace and SpaceToDepth
Jun 20, 2024
Skip to content
Navigation Menu
{{ message }}
-
-
Notifications
You must be signed in to change notification settings - Fork 56.2k
dnn: add DepthToSpace and SpaceToDepth #25779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
asmorkalov
merged 13 commits into
opencv:4.x
from
fengyuentau:dnn/fix_onnx_depthtospace
Jun 21, 2024
Merged
dnn: add DepthToSpace and SpaceToDepth #25779
asmorkalov
merged 13 commits into
opencv:4.x
from
fengyuentau:dnn/fix_onnx_depthtospace
Jun 21, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
dkurt
reviewed
Jun 20, 2024
dkurt
reviewed
Jun 20, 2024
zihaomu
approved these changes
Jun 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👍
Failed CUDA tests:
|
…n tensor/tensorspan/tensorview.reshape
Thank you for listing the error on CUDA backend. Hopefully the latest commit can fix this problem. |
dkurt
approved these changes
Jun 21, 2024
asmorkalov
reviewed
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
category:dnn_cann
CANN backend related issues in DNN module
category: dnn (onnx)
ONNX suport issues in DNN module
category:dnn_timvx
TIM-VX related issues in DNN module
feature
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
We are working on updating WeChat QRCode module. One of the new models is a fully convolutional model and hence it should be able to run with different input shapes. However, it has an operator
DepthToSpace
, which is parsed as a subgraph ofReshape -> Permute -> Reshape
with a fixed shape getting during parsing. The subgraph itself is not a problem, but the true problem is the subgraph with a fixed input and output shape regardless input changes. This does not allow the model to run with different input shapes.Solution is to add a dedicated layer for DepthtoSpace and SpaceToDepth.
Backend support:
Vulkan(missing fundamental tools, like permutation and reshape)Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.