CARVIEW |
Select Language
HTTP/2 302
date: Mon, 21 Jul 2025 09:11:26 GMT
content-length: 0
location: https://github.com/opencv/opencv/pull/25673
server-timing: nginx;desc="NGINX";dur=0.694,glb;desc="GLB";dur=95.588047
x-voltron-version: fd8fbbc
vary: Accept-Encoding, Accept, X-Requested-With
server: github.com
x-frame-options: DENY
strict-transport-security: max-age=31536000; includeSubDomains; preload
set-cookie: _gh_sess=2WnMf8DaAJLeWrlMZOUFxQ7m0cVfVYmliTAxjMFPWaaHHwrZysDs%2FJCCBzGbnjZSo7ZBkVF1qgTj97cCgR6crIzHx7cUXTp9utzQhJCQ5GwPZo1gO%2B7%2FBgam21uoY5Ux0VAwnevILUIETVOR%2FJ2aM%2F4HRF9fzmnjRNE2E%2FfFAzfhECg9teX9s8tCdS4lvSSGi4wRcTSh3jRNsXWXPIUcnKlUHWRfkxuSUemy8kn42cbGZBloZoB35TNKq%2FVlEHe8jJ%2BJZxAg%2FhYLLEncycv6mQ%3D%3D--dJQQcs4IvRWnIav5--HnomgfBP7DkKWRqsYkJKMw%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1831646155.1753089086; Path=/; Domain=github.com; Expires=Tue, 21 Jul 2026 09:11:26 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Tue, 21 Jul 2026 09:11:26 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: 9D76:305A02:13CE39B:192E908:687E043E
HTTP/2 200
date: Mon, 21 Jul 2025 09:11:27 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=397.092511,conversation_content-fragment;desc="conversation_content fragment";dur=792.916147,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=274.934266,nginx;desc="NGINX";dur=1.179784,glb;desc="GLB";dur=95.827728
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: fd8fbbc
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
x-github-request-id: 9D76:305A02:13CE3FC:192E97B:687E043E
fixed marker generation in charuco board by AleksandrPanov · Pull Request #25673 · opencv/opencv · GitHub
AleksandrPanov
added
bug
category: objdetect
pr: needs test
New functionality requires minimal tests set
labels
May 30, 2024
AleksandrPanov
added
test
and removed
pr: needs test
New functionality requires minimal tests set
labels
May 30, 2024
AleksandrPanov
force-pushed
the
fix_charuco_board_markers
branch
from
May 31, 2024 06:38
AleksandrPanov
force-pushed
the
fix_charuco_board_markers
branch
from
May 31, 2024 08:13
Skip to content
Navigation Menu
{{ message }}
-
-
Notifications
You must be signed in to change notification settings - Fork 56.2k
fixed marker generation in charuco board #25673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
asmorkalov
merged 2 commits into
opencv:4.x
from
AleksandrPanov:fix_charuco_board_markers
May 31, 2024
Merged
fixed marker generation in charuco board #25673
asmorkalov
merged 2 commits into
opencv:4.x
from
AleksandrPanov:fix_charuco_board_markers
May 31, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4059ec9
to
267bd62
Compare
asmorkalov
requested changes
May 31, 2024
267bd62
to
3cb6766
Compare
asmorkalov
approved these changes
May 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
When generating Charuco board markers in
generateImage()
, a problem occurs as in #24806, #24873:In low resolution:


In medium resolution:
This PR fixed this problems:


The test checks the inner and outer borders of the Aruco markers. In the outer border of Aruco marker, all pixels should be white. In the inner border of Aruco marker, all pixels should be black.

Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.