| CARVIEW |
Select Language
HTTP/2 302
date: Tue, 22 Jul 2025 21:48:31 GMT
content-length: 0
location: https://github.com/opencv/opencv/pull/25662
server-timing: nginx;desc="NGINX";dur=0.860541,glb;desc="GLB";dur=101.987422
x-voltron-version: fd8fbbc
vary: Accept-Encoding, Accept, X-Requested-With
server: github.com
x-frame-options: DENY
strict-transport-security: max-age=31536000; includeSubDomains; preload
set-cookie: _gh_sess=YpG8mMrYIvkEMRh7pw9DFXGjKANWPYzP98dBc1U8cHT7VLkdUbks1ITg94nGNiwheHDnwmyrlDiKD4EgLnW8q3qO6Ef1IpGd0Wrho%2B34CcaUVmz%2FR%2BWdhWf8WLcaBn3odwrk9yXf46Nr6AQqf%2BWni%2BE7xzYYpAycxPoaoV%2FdpF1%2BBm1I%2Bs6TRmSbpouJtQiXUeUbO87URf0mrPK9inxRztpP2YGn1E6nwU8A5ZNfT7camJZYc%2BnDAp%2FBeWobPcmCKJrRBd7TEaudUl9GcPq8%2FA%3D%3D--9mU%2FDQsPM2FStZpN--13at9RD8SViPpvJa8yCIdg%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1932078383.1753220911; Path=/; Domain=github.com; Expires=Wed, 22 Jul 2026 21:48:31 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Wed, 22 Jul 2026 21:48:31 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: CFD2:271430:160BF7:1D5438:6880072F
HTTP/2 200
date: Tue, 22 Jul 2025 21:48:32 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=367.18286,conversation_content-fragment;desc="conversation_content fragment";dur=917.06988,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=234.008304,nginx;desc="NGINX";dur=1.019349,glb;desc="GLB";dur=102.575421
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: fd8fbbc
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
x-github-request-id: CFD2:271430:160C0B:1D545C:6880072F
Port G-API ONNXRT backend into V2 API by ujjayant-kadian · Pull Request #25662 · opencv/opencv · GitHub
Skip to content
Navigation Menu
{{ message }}
-
-
Notifications
You must be signed in to change notification settings - Fork 56.2k
Port G-API ONNXRT backend into V2 API #25662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
asmorkalov
merged 11 commits into
opencv:4.x
from
ujjayant-kadian:uk/port-gapi-onnxrt-backend-into-v2-api
May 31, 2024
Merged
Port G-API ONNXRT backend into V2 API #25662
asmorkalov
merged 11 commits into
opencv:4.x
from
ujjayant-kadian:uk/port-gapi-onnxrt-backend-into-v2-api
May 31, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Added a new member function cfgParamsMap that allows setting multiple configuration options for the OpenVINO Execution Provider by passing a map of key-value pairs, where the key is the name of the option and the value is the setting for that option. The function will throw an error if an attempt is made to set an option that has already been set or if an unknown option is provided. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
One suggestion here, most probably it's better to introduce another ctor that accepts the map rather than new handle. In that case we could prohibit using the cfg handles.
auto ovep = cv::gapi::onnx::ep::OpenVINO({"device_type", "CPU"}, {...}});
ovep.cfgNumThreads(4) // Throw: ep::OpenVINO cannot be changed if created from the parameters map.
and at the backend side we could simply check if parameters_map is empty or not, and if not - pass it "as-is" to onnxrt, otherwise populate it by using existing per-option members.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Just minor comments!
is_initialised_from_map
TolyaTalamanov
approved these changes
May 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! LGTM đź‘Ť
@dmatveev Could you have a look, please?
dmatveev
approved these changes
May 31, 2024
|
đź‘ŤI am fine with it, thanks @ujjayant-kadian ! |
|
@asmorkalov Could you merge this, please? |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.