CARVIEW |
Select Language
HTTP/2 302
date: Mon, 21 Jul 2025 11:27:48 GMT
content-length: 0
location: https://github.com/opencv/opencv/pull/25319
server-timing: nginx;desc="NGINX";dur=0.887083,glb;desc="GLB";dur=100.814189
x-voltron-version: fd8fbbc
vary: Accept-Encoding, Accept, X-Requested-With
server: github.com
x-frame-options: DENY
strict-transport-security: max-age=31536000; includeSubDomains; preload
set-cookie: _gh_sess=h6ozX4rastTWhOuWGRYQVr4ziLeTO9dPBmyq3j8mJpB2lK42WW%2B7hl3Rgp%2BbcL%2B1V1GetbOO3dmO5DXrMZUEFuP9f1YV6o77b5%2B3S2z5KXq06GsG3X8Pr3Ffoav3U0YdLvUdD5op0sGg%2FV07ASE%2FOYADs1a6rHL4w8Fx%2F%2Bx7PPrq%2BZjtjU0pDTQgEDuyNwg9INYDejNRmOLBIKTigB7XGrOKIvMBjX2h1gK2Qq4C82pHbVyXD05k0%2BwaXhJ3wMuAGMUbUma6euWWJtjz0dC9SQ%3D%3D--nGO83b9epXjn1NMY--IUGO67%2F9T0KB7%2FLIEkK%2Fiw%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1897801596.1753097268; Path=/; Domain=github.com; Expires=Tue, 21 Jul 2026 11:27:48 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Tue, 21 Jul 2026 11:27:48 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: D9FC:36E64:CE0BEB:F9FB23:687E2434
HTTP/2 200
date: Mon, 21 Jul 2025 11:27:49 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=448.24025,conversation_content-fragment;desc="conversation_content fragment";dur=983.734083,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=311.324664,nginx;desc="NGINX";dur=1.366492,glb;desc="GLB";dur=119.159467
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: fd8fbbc
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
x-github-request-id: D9FC:36E64:CE0C5B:F9FBA3:687E2434
[BugFix] dnn (ONNX): Foce dropping constant inputs in `parseClip` if they are shared by fengyuentau · Pull Request #25319 · opencv/opencv · GitHub
[BugFix] dnn (ONNX): Foce dropping constant inputs in
fengyuentau
added
category: dnn
category: dnn (onnx)
ONNX suport issues in DNN module
labels
Apr 3, 2024
Skip to content
Navigation Menu
{{ message }}
-
-
Notifications
You must be signed in to change notification settings - Fork 56.2k
[BugFix] dnn (ONNX): Foce dropping constant inputs in parseClip
if they are shared
#25319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should we add Gold-YOLO in the integrated YOLO API? @Abdurrahheem |
4 tasks
dkurt
reviewed
Apr 3, 2024
dkurt
approved these changes
Apr 3, 2024
Merged
klatism
pushed a commit
to klatism/opencv
that referenced
this pull request
May 17, 2024
[BugFix] dnn (ONNX): Foce dropping constant inputs in parseClip if they are shared opencv#25319 Resolves opencv#25278 Merge with opencv/opencv_extra#1165 In Gold-YOLO ,`Div` has a constant input `B=6` which is then parsed into a `Const` layer in the ONNX importer, but `Clip` also has the shared constant input `max=6` which is already a `Const` layer and then connected to `Elementwise` layer. This should not happen because in the `forward()` of `Elementwise` layer, the legacy code goes through and apply activation to each input. More details on opencv#25278 (comment). ### Pull Request Readiness Checklist See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request - [x] I agree to contribute to the project under Apache 2 License. - [x] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV - [x] The PR is proposed to the proper branch - [x] There is a reference to the original bug report and related work - [x] There is accuracy test, performance test and test data in opencv_extra repository, if applicable Patch to opencv_extra has the same branch name. - [x] The feature is well documented and sample code can be built with the project CMake
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Resolves #25278
Merge with opencv/opencv_extra#1165
In Gold-YOLO ,
Div
has a constant inputB=6
which is then parsed into aConst
layer in the ONNX importer, butClip
also has the shared constant inputmax=6
which is already aConst
layer and then connected toElementwise
layer. This should not happen because in theforward()
ofElementwise
layer, the legacy code goes through and apply activation to each input. More details on #25278 (comment).Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.