Fix for OpenVINO 2024.0. OpenVINO 2022.1 as minimal supported version. #25199

olpipi · 2024-03-11T16:42:29Z

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

I agree to contribute to the project under Apache 2 License.
To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
The PR is proposed to the proper branch
There is a reference to the original bug report and related work
There is accuracy test, performance test and test data in opencv_extra repository, if applicable
Patch to opencv_extra has the same branch name.
The feature is well documented and sample code can be built with the project CMake

modules/dnn/src/ie_ngraph.hpp

dkurt · 2024-03-11T17:29:03Z

Thanks, @olpipi! Our CI uses OpenVINO 2023.0.2.

Can you determine on which minimal version ov:: namespace and required headers are available? To understand which would be a minimal required version to support.

modules/dnn/src/ie_ngraph.cpp

olpipi · 2024-03-11T17:46:09Z

Thanks, @olpipi! Our CI uses OpenVINO 2023.0.2.

Can you determine on which minimal version ov:: namespace and required headers are available? To understand which would be a minimal required version to support.

Hi
No problem. I'll check it

dkurt · 2024-03-11T18:45:31Z

Please note that as a part of regular CI we test 2021.4.2 release (OpenVINO API 1.0): https://pullrequest.opencv.org/buildbot/builders/4_x_openvino-opencl-skl-lin64/builds/100055

If there is no ov namespace in 2021.4.2, I still recommend to replace ngraph:: to ov:: however with a workaround for old release:

namespace ov = ngraph;

modules/dnn/src/layers/elementwise_layers.cpp

olpipi · 2024-03-12T11:09:00Z

@dkurt OpenVINO 2021.4.2 has neither ov namespace nor "openvino/..." include pathes. So I'll fix it as you suggested.

Can we somehow test it with 2024.0 release as well, except my local testing?

modules/dnn/src/ie_ngraph.hpp

ilya-lavrenov · 2024-03-13T21:53:58Z

modules/dnn/src/layers/detection_output_layer.cpp

@@ -55,11 +55,7 @@

 #ifdef HAVE_DNN_NGRAPH


HAVE_DNN_NGRAPH => HAVE_DNN_OPENVINO ?

Will cost a lot of changes as well as DNN_BACKEND_INFERENCE_ENGINE -> DNN_BACKEND_OPENVINO.

ilya-lavrenov · 2024-03-13T21:55:39Z

modules/dnn/src/net_openvino.cpp

@@ -9,6 +9,12 @@
 #include <opencv2/core/utils/configuration.private.hpp>
 #include <opencv2/core/utils/logger.hpp>

+#include "op_inf_engine.hpp"
+
+#ifdef HAVE_INF_ENGINE


Suggested change

#ifdef HAVE_INF_ENGINE

#ifdef HAVE_OPENVINO

ilya-lavrenov · 2024-03-13T21:55:58Z

modules/dnn/src/net_openvino.cpp

@@ -864,15 +804,8 @@ Net openvino_readNetwork(
    InferenceEngine::CNNNetwork ieNet;


it's removed in API 2.0

This is a workaround to wrap ov::Model from API 2.0: https://github.com/opencv/opencv/pull/25199/files#r1524623439

ilya-lavrenov · 2024-03-13T21:56:15Z

modules/dnn/src/op_inf_engine.cpp

@@ -10,7 +10,7 @@
 #include <opencv2/dnn/shape_utils.hpp>

 #ifdef HAVE_INF_ENGINE


Suggested change

#ifdef HAVE_INF_ENGINE

#ifdef HAVE_OPENVINO

ilya-lavrenov · 2024-03-13T21:57:18Z

modules/dnn/src/op_inf_engine.hpp

@@ -28,6 +28,7 @@
 #define INF_ENGINE_RELEASE_2021_4 2021040000
 #define INF_ENGINE_RELEASE_2022_1 2022010000
 #define INF_ENGINE_RELEASE_2023_0 2023000000
+#define INF_ENGINE_RELEASE_2024_0 2024000000


Suggested change

#define INF_ENGINE_RELEASE_2024_0 2024000000

#define OPENVINO_RELEASE_2024_0 2024000000

and can we remove old ones?

Let’s remove old ones, but keep IE notation to reduce changes.

modules/dnn/src/op_inf_engine.hpp

modules/dnn/test/test_ie_models.cpp

dkurt

Great job, many thanks!

olpipi · 2024-03-18T08:05:24Z

Hi @dkurt.
Can we merge this PR or any extra actions are required?

dkurt · 2024-03-18T08:07:33Z

@olpipi, Need a comment from @opencv-alalek regarding https://pullrequest.opencv.org/buildbot/builders/4_x_openvino-opencl-skl-lin64/ (uses 2021.4.2 OpenVINO). Is that critical if we merge this PR to 4.x before CI upgrade?

opencv-alalek

Well done 👍

@olpipi Please squash commits into one before merge

OpenVINO builder on legacy CI will be upgraded later.

Remove support OpenVINO lower than 2022.1 release Remove legacy InferenceEngine wrappers

olpipi · 2024-03-18T11:06:43Z

Well done 👍

@olpipi Please squash commits into one before merge

OpenVINO builder on legacy CI will be upgraded later.

Done. Squashed and rebased

CSBVision · 2024-07-16T07:08:41Z

After OpenCV's 4.10.0 release including this patch, we tried to upgrade to OpenVINO 2024, too. However, compiling OpenVINO 2024.2.0 with basically only the CPU plugin, linking OpenCV against it and using model.setPreferableBackend(cv.dnn.DNN_BACKEND_INFERENCE_ENGINE), we get the following runtime error in model.forward():

error: OpenCV(4.10.0) opencv\modules\dnn\src\ie_ngraph.cpp:558: error: (-215:Assertion failed) blobIt != allBlobs.end() in function 'cv::dnn::InfEngineNgraphNet::forward'

Ìt works without any issues if either OpenCV's backend is used or the OpenVINO's 2024 release is replaced by 2023 (we tested 2023.3.0), i.e. it is directly caused by using OpenVINO's 2024 release. We also tested different models, the error is always the same. Any ideas what's causing it?

asmorkalov · 2024-07-16T08:24:36Z

@CSBVision could you file a bug with small reproducer and particular OpenVINO versions.

CSBVision · 2024-07-16T09:05:13Z

Sure, no problem, cf. #25916
We only wanted to discuss the issue here before opening a new one.

related: opencv#25199

olpipi force-pushed the fix_openvino_2024_0 branch from 7675ec1 to 0fabe2b Compare March 11, 2024 16:51

dkurt linked an issue Mar 11, 2024 that may be closed by this pull request

OpenVINO nGraph API will be removed in 2024 #24589

Closed

dkurt reviewed Mar 11, 2024

View reviewed changes

modules/dnn/src/ie_ngraph.hpp Outdated Show resolved Hide resolved

dkurt reviewed Mar 11, 2024

View reviewed changes

modules/dnn/src/ie_ngraph.cpp Outdated Show resolved Hide resolved

dkurt reviewed Mar 11, 2024

View reviewed changes

modules/dnn/src/layers/elementwise_layers.cpp Outdated Show resolved Hide resolved

dkurt mentioned this pull request Mar 12, 2024

OpenVINO 2024.0.0 opencv-infrastructure/opencv-gha-dockerfile#35

Merged

ilya-lavrenov mentioned this pull request Mar 12, 2024

Rebuild for libopenvino_dev 2024 conda-forge/opencv-feedstock#397

Merged

dkurt reviewed Mar 13, 2024

View reviewed changes

modules/dnn/src/ie_ngraph.hpp Outdated Show resolved Hide resolved

dkurt marked this pull request as ready for review March 13, 2024 11:00

dkurt marked this pull request as draft March 13, 2024 11:00

ilya-lavrenov reviewed Mar 13, 2024

View reviewed changes

dkurt linked an issue Mar 14, 2024 that may be closed by this pull request

Drop old OpenVINO support #25207

Closed

3 tasks

dkurt changed the title ~~Fix for OpenVINO 2024.0~~ Fix for OpenVINO 2024.0. OpenVINO 2022.1 as minimal supported version. Mar 14, 2024

opencv-alalek added optimization feature category: dnn category: 3rdparty cleanup Code cleanup (e.g, drop legacy C-API, legacy unmaintained code) labels Mar 14, 2024

dkurt reviewed Mar 14, 2024

View reviewed changes

modules/dnn/src/op_inf_engine.hpp Outdated Show resolved Hide resolved

dkurt reviewed Mar 14, 2024

View reviewed changes

modules/dnn/test/test_ie_models.cpp Show resolved Hide resolved

olpipi marked this pull request as ready for review March 14, 2024 15:30

olpipi marked this pull request as draft March 14, 2024 15:30

olpipi marked this pull request as ready for review March 14, 2024 19:24

dkurt approved these changes Mar 15, 2024

View reviewed changes

dkurt requested a review from opencv-alalek March 15, 2024 12:26

p-durandin approved these changes Mar 18, 2024

View reviewed changes

ilya-lavrenov approved these changes Mar 18, 2024

View reviewed changes

opencv-alalek approved these changes Mar 18, 2024

View reviewed changes

Fix for OpenVINO 2024.0

6da2ddc

Remove support OpenVINO lower than 2022.1 release Remove legacy InferenceEngine wrappers

olpipi force-pushed the fix_openvino_2024_0 branch from 9e9b879 to 6da2ddc Compare March 18, 2024 11:06

opencv-alalek added this to the 4.10.0 milestone Mar 18, 2024

opencv-alalek assigned dkurt Mar 18, 2024

opencv-pushbot merged commit 0c6fc76 into opencv:4.x Mar 19, 2024

This was referenced Mar 19, 2024

Rebuild libopenvino dev2024 0 1 h50e462 conda-forge/opencv-feedstock#399

Merged

openvino 2024.0.0 Homebrew/homebrew-core#165084

Merged

asmorkalov mentioned this pull request Apr 1, 2024

5.x merge 4.x #25305

Merged

CSBVision mentioned this pull request Jul 16, 2024

Default DNN backend not set correctly #25112

Open

4 tasks

AvenSun added a commit to AvenSun/opencv that referenced this pull request Aug 3, 2024

fix compilation errors caused by namespace

796974c

related: opencv#25199

AvenSun mentioned this pull request Aug 3, 2024

fix compilation errors caused by namespace #25987

Merged

6 tasks

asmorkalov mentioned this pull request Aug 6, 2024

(5.x) Merge 4.x #25998

Merged

fengyuentau pushed a commit to fengyuentau/opencv that referenced this pull request Aug 15, 2024

fix compilation errors caused by namespace

e3d9262

related: opencv#25199

thewoz pushed a commit to CobbsLab/OPENCV that referenced this pull request Feb 13, 2025

fix compilation errors caused by namespace

90a96fe

related: opencv#25199

		@@ -864,15 +804,8 @@ Net openvino_readNetwork(
		InferenceEngine::CNNNetwork ieNet;

		@@ -10,7 +10,7 @@
		#include <opencv2/dnn/shape_utils.hpp>

		#ifdef HAVE_INF_ENGINE

	#define INF_ENGINE_RELEASE_2024_0 2024000000
	#define OPENVINO_RELEASE_2024_0 2024000000

Uh oh!

Fix for OpenVINO 2024.0. OpenVINO 2022.1 as minimal supported version. #25199

Fix for OpenVINO 2024.0. OpenVINO 2022.1 as minimal supported version. #25199

Uh oh!

Conversation

olpipi commented Mar 11, 2024 • edited by dkurt Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request Readiness Checklist

Uh oh!

Uh oh!

dkurt commented Mar 11, 2024

Uh oh!

Uh oh!

olpipi commented Mar 11, 2024

Uh oh!

dkurt commented Mar 11, 2024

Uh oh!

Uh oh!

olpipi commented Mar 12, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

dkurt left a comment

Choose a reason for hiding this comment

Uh oh!

olpipi commented Mar 18, 2024

Uh oh!

dkurt commented Mar 18, 2024

Uh oh!

opencv-alalek left a comment

Choose a reason for hiding this comment

Uh oh!

olpipi commented Mar 18, 2024

Uh oh!

CSBVision commented Jul 16, 2024

Uh oh!

asmorkalov commented Jul 16, 2024

Uh oh!

CSBVision commented Jul 16, 2024

Uh oh!

Uh oh!

olpipi commented Mar 11, 2024 •

edited by dkurt

Loading

olpipi commented Mar 12, 2024 •

edited

Loading