You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As tests are claimed as duplicates, you run these tests and should see the same result numbers at least.
This is not true and assumption is wrong. Tests should be restored as they test different usecases on different images.
I removed tests with bardet.detectMulti(src, corners);
The func detectMulti() just call detect() from PIMPL:
I left tests with bardet.detectAndDecodeWithType(src, decoded_info, decoded_type, corners);
The func detectAndDecodeWithType() call detect() from PIMPL:
Therefore, the detect() function continues to be tested.
I'm not sure why we need to run the detectMulti() function in our "perf" tests. It is already being tested in BarcodeDetector_main.interface (test_barcode.cpp).
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The method
detectAndDecode()
in theBarcodeDetector
class doesn't return the barcode corners.This PR fixes the and add test for
detectAndDecode
.Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.